Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default base URI for SendGrid doesn't match SendGrid docs #544

Closed
camelpunch opened this issue Aug 10, 2020 · 1 comment · Fixed by #545
Closed

Default base URI for SendGrid doesn't match SendGrid docs #544

camelpunch opened this issue Aug 10, 2020 · 1 comment · Fixed by #545
Labels
adapter Related to supported adapters

Comments

@camelpunch
Copy link

I'm running a strict environment in Istio where all outbound traffic must be allowed explicitly. I had to read the source code of Bamboo to confirm it was using sendgrid.com and not api.sendgrid.com.

Although the former works, I imagine that SendGrid would want the flexibility to turn this off one day, and perhaps we should be using api.sendgrid.com instead?

See e.g. https://sendgrid.com/docs/for-developers/sending-email/api-getting-started/

@germsvel
Copy link
Collaborator

germsvel commented Aug 11, 2020

Thanks for opening this issues @camelpunch! It seems like that was changed when we adopted v3 of the api in this commit. But you're totally correct in that it seems we should be using the https://api.sendgrid.com/v3/ instead of what we're doing now.

I'd like to make sure that changing that url won't cause any breakages, but I can't imagine it doing so. Still, I'll do some due diligence and open a PR, unless someone else is willing to do that!

@germsvel germsvel added the adapter Related to supported adapters label Aug 11, 2020
camelpunch added a commit to code-supply/code-supply that referenced this issue Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapter Related to supported adapters
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants