Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click Tracking settings for SendGrid Adapter #596

Closed
ehsieh opened this issue Apr 2, 2021 · 1 comment · Fixed by #618
Closed

Click Tracking settings for SendGrid Adapter #596

ehsieh opened this issue Apr 2, 2021 · 1 comment · Fixed by #618

Comments

@ehsieh
Copy link

ehsieh commented Apr 2, 2021

SendGrid allows for click tracking to be enabled/disabled on a per email basis:

https://sendgrid.com/docs/ui/account-and-settings/tracking/#click-tracking

image

I imagine this could be implemented in the same fashion as the current Google Analytics settings support (#462)

I'd be happy to open PR for this!
@germsvel
Copy link
Collaborator

germsvel commented Apr 9, 2021

Hi @ehsieh (it's good to see you!). Thanks for opening this issue. I'd be happy to review a PR.

Even though there isn't a defined standard, most helper functions in the SendGridHelper use the with_x format to set values when composing an email (just like the google analytics PR you included). So, I imagine we could follow that pattern, unless there's a more descriptive way to set the click tracking.

@sreecodeslayer sreecodeslayer mentioned this issue Jul 29, 2021
Merged
germsvel pushed a commit that referenced this issue Aug 20, 2021
@sreecodeslayer
Adds support for enabling sendgrid click tracking (#618)
0104d71 
Resolve #596 

Adds support for enabling click_tracking for sendgrid emails. 
The commit sets both `enabled` and `enabled_text` for HTML 
and text-only emails. 

Consider Sendgrid's message for click tracking: 

> It's important to consider the privacy implications of enabling Click and Open tracking before enabling the feature. Depending on the country where your recipient resides, using this feature to track engagement may require the unambiguous consent of the recipient.

References: 

https://docs.sendgrid.com/ui/account-and-settings/tracking
https://docs.sendgrid.com/api-reference/settings-tracking/update-click-tracking-settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve #596 : add support for enabling sendgrid click tracking sreecodeslayer/bamboo
2 participants
@ehsieh @germsvel