Add support for replyto parameter with SendGrid #254
Conversation
| @@ -156,6 +157,14 @@ defmodule Bamboo.SendgridAdapter do | |||
| defp put_text_body(body, %Email{text_body: nil}), do: body | |||
| defp put_text_body(body, %Email{text_body: text_body}), do: Map.put(body, :text, text_body) | |||
|
|
|||
| # If you would like to add a replyto header to your email, then simply pass it in | |||
| # using the header property or put_header function like so: | |||
| # put_header("reply-to", "foo@bar.com") | |||
There was a problem hiding this comment.
I think this comment would be better in the moduledoc at the top. Right above # Example Config
What do you think?
| # or you can use functions to build it up step by step | ||
| base_email | ||
| |> to(user) | ||
| |> subject("Welcome!") | ||
| |> text_body("Welcome to the app") | ||
| |> html_body("<strong>Welcome to the app</strong>") | ||
| end | ||
|
|
| @@ -144,6 +144,17 @@ defmodule Bamboo.SendgridAdapterTest do | |||
| }} | |||
| end | |||
|
|
|||
| test "deliver/2 correctly formats sendto from headers" do | |||
There was a problem hiding this comment.
I believe sendto should be reply-to
| test "deliver/2 correctly formats sendto from headers" do | ||
| email = new_email( | ||
| headers: %{"reply-to" => "foo@bar.com"} | ||
| ) |
There was a problem hiding this comment.
I think this would look a bit better all on one line. What do you think?
|
@cjpwrs If you are busy I'm happy to finish this off for you. LMK if you need any help :D |
|
@paulcsmith Hey sorry I just saw these comments! Thanks for the review! I'll make those changes real quick and let you know once they are pushed up. |
|
@paulcsmith Alright those changes have been made and merge conflicts resolved. Let me know if you find anything else you want me to change. Thanks! |
| @@ -5,6 +5,10 @@ defmodule Bamboo.SendGridAdapter do | |||
| Use this adapter to send emails through SendGrid's API. Requires that an API | |||
| key is set in the config. | |||
|
|
|||
| If you would like to add a replyto header to your email, then simply pass it in | |||
| using the header property or put_header function like so: | |||
| put_header("reply-to", "foo@bar.com") | |||
There was a problem hiding this comment.
If you put this one more line down and indent it 4 spaces it will be highlighted as code, which I think would look nice and draw the reader's attention
There was a problem hiding this comment.
@paulcsmith Oh nice that's good to know! K, that change is pushed 👍
I user can pass in a
reply-toheader, and the SendGrid adapter will format that so that a replyto parameter can be set on an email. This does not change any current functionality, simply adds a new feature to the SendGrid adapter.