-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support attachments in SendGridAdapter #294
Support attachments in SendGridAdapter #294
Conversation
@randycoulman #292 is merged 🎉 🌮 |
@schurig I saw that. My open source time is limited, but I'll try to get a rebase done when I can in the next day or two. |
dc8e927
to
c39d8b2
Compare
I rebased #293 onto the latest master and then rebased this branch on top of that one. |
OK, changes made. This one should be ready to go once #293 has been merged. |
hey, we've tried this branch and it works great when sending emails with attachment. it breaks for emails without attachment however. |
@manukall Oh, good catch! I thought I'd tested that in our application, but perhaps not. I'll try to address that as soon as I can (probably in a day or two). |
@manukall I just pushed up another commit that addresses the issue you found. I did it a bit differently: |
@randycoulman thanks for doing this! I just started a small Elixir project last Thursday that we've been using in production since then. Its just meant to send 3 CSV data dump reports as an email attachment using SendGrid. This has worked great for us! No issues sending emails with attachments from a local file or using raw data. Its worked flawlessly. Please let me know if you need help/confirmation on changes here as I can help test it as it gets reviewed. Thanks again! ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@randycoulman Thanks so much for this! Could you rebase to get the conflicts in mix.lock fixed? Once that's done I can merge this in :D
@paulcsmith I'll rebase once #293 has been merged. |
#293 is in! Thanks so much for the quick response! |
cad11a3
to
38f740f
Compare
@paulcsmith Rebased! |
Thank you! :D |
great feature. let me suggest to add attachment to emails direct from a function call (instead of saving on the disk before sending). |
WARNING This PR is built using the v3 SendGrid API that is currently pending in #293, so that PR should be merged first and then this PR rebased on top of master. All of the diffs that are unique to this PR start at commit dc8e927.
Adds attachment support to
SendGridAdapter
. The code and tests are very similar toMandrillAdapter
.If #292 gets merged before this PR, I'm happy to make the necessary changes here.