Add support for SendGrid's asm_group_id #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for letting recipients unsubscribe from certain types of email communication. By assigning an ASM group id to the email, hitting "Unsubscribe" in the footer will unsubscribe the recipient only from this email group, not all communication.
|
This change looks good (and is something we need to get unsubscribe links to work properly with SendGrid). Is there any chance of cleaning up the conflicts and getting this merged in? |
|
I've cleaned up the "conflict" (it was just some indenting issue), so maintainers are welcome to merge this if they so wish! |
|
It'd be great to get this merged! Can I help? |
| @@ -83,6 +84,23 @@ defmodule Bamboo.SendGridHelper do | |||
| raise "expected a list of category strings" | |||
| end | |||
|
|
|||
| @doc """ | |||
| An integer id for an ASM (Advanced Suppression Manager) group that this email should belong to. | |||
| This can be used to let receipients unsubscribe from only a certain type of communication. | |||
There was a problem hiding this comment.
"receipients" -> "recipients"
|
To help getting this merged I've made the changes suggested in a new pull request: #457. |
|
Closing this since the changes were incorporated in #457. Thanks for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for letting recipients unsubscribe from certain types of email communication. By assigning an ASM group id to the email, hitting "Unsubscribe" in the footer will unsubscribe the recipient only from this email group, not all emails.