Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate circleci configuration to 2.0 #411

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

kalys
Copy link
Contributor

@kalys kalys commented Jul 6, 2018

No description provided.

@joshchernoff
Copy link
Contributor

Why was there a change made to mix.lock ?

Copy link
Contributor

@joshchernoff joshchernoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are two areas you could drop

- run: mix test
- run: MIX_ENV=prod mix compile

- store_test_results: # upload test results for display in Test Summary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure storing test results is necessary, though I could be wrong.

key: v1-build-cache
paths: "_build"
- run: mix test
- run: MIX_ENV=prod mix compile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found this is helpful to catch things that may only cause issues in prod.

Copy link
Contributor

@paulcsmith paulcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!

paths: "deps"
- save_cache:
key: v1-mix-cache
paths: "deps"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used Circle 2.0 that much yet. Could you explain why multiple caches are needed here?

key: v1-build-cache
paths: "_build"
- run: mix test
- run: MIX_ENV=prod mix compile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found this is helpful to catch things that may only cause issues in prod.

@kalys
Copy link
Contributor Author

kalys commented Aug 7, 2018

@joshchernoff

Why was there a change made to mix.lock ?

I have a newer version of elixir and mix. And mix made this changes. I'll revert them.

@kalys
Copy link
Contributor Author

kalys commented Aug 7, 2018

@joshchernoff @paulcsmith
I used this file https://circleci.com/docs/2.0/language-elixir/#sample-configuration

Maybe cost of network traffic is higher than cost of storage and that's why they recommend to cache every version, branch and change of mix.lock.

@kalys kalys force-pushed the migrate-to-circleci-2.0 branch 2 times, most recently from 3b1e28f to d3c5cec Compare August 7, 2018 03:44
@kalys
Copy link
Contributor Author

kalys commented Aug 7, 2018

@joshchernoff @paulcsmith Ok. I removed all caches except one that depends on checksum of mix.lock. Also I removed v1- prefix from cache name.

@paulcsmith
Copy link
Contributor

Thank you so much!

@paulcsmith paulcsmith merged commit acd1cba into beam-community:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants