Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and clarify documentation #468

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Conversation

lancejjohnson
Copy link
Contributor

While reading through Bamboo's source code, there were a few places in
the documentation I found that could be clearer or had minor typos. This
commit aims to clarify some of the documentation and fix minor typos
here and there.

Copy link
Contributor

@maymillerricci maymillerricci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just a couple small comments. Thanks so much for doing this. 🌟

lib/bamboo/mailer.ex Show resolved Hide resolved
lib/bamboo/plug/sent_email_api/sent_email_api_plug.ex Outdated Show resolved Hide resolved
Copy link
Contributor

@jutonz jutonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is awesome!

lib/bamboo/mailer.ex Show resolved Hide resolved
While reading through Bamboo's source code, there were a few places in
the documentation I found that could be clearer or had minor typos. This
commit aims to clarify some of the documentation and fix minor typos
here and there.
@lancejjohnson lancejjohnson merged commit 89845a8 into master Apr 2, 2019
@lancejjohnson lancejjohnson deleted the ljj/docs-cleanup branch April 2, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants