Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an adapter for Campaign Monitor #477

Closed
wants to merge 2 commits into from
Closed

Add an adapter for Campaign Monitor #477

wants to merge 2 commits into from

Conversation

jackmarchant
Copy link
Contributor

Hey 👋
We've needed to migrate from SendGrid to Campaign Monitor, so we've written an adapter for it, and largely based it off the SendGrid adapter.

Currently, it supports classic email and smart email, but Smart email is not documented or tested well yet. I wanted to check first to see if this is something you want to add before spending too much time on it, happy to update it before merging too.

https://www.campaignmonitor.com/api/transactional/#send-classic-email
https://www.campaignmonitor.com/api/transactional/#send-smart-email

@maymillerricci
Copy link
Contributor

@jackmarchant Thanks for this! At this point our preference is for new adapters to be their own separate libraries. See for example the others under https://github.com/thoughtbot/bamboo#available-adapters. Can you implement this as its own library? Then we can add a link to your new one to the list as well. 😄

@jackmarchant
Copy link
Contributor Author

Yes, no problem at all! I just thought I’d submit a PR here in case. I’ll submit a PR when it’s ready

Thank you!

@jackmarchant jackmarchant deleted the campaign-monitor-adapter branch May 11, 2019 03:43
@jackmarchant
Copy link
Contributor Author

#480
@maymillerricci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants