Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Mandrill to return ok/error tuples #574

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Update Mandrill to return ok/error tuples #574

merged 1 commit into from
Feb 19, 2021

Conversation

germsvel
Copy link
Collaborator

Requires: #571

What changed?

Update MandrillAdapter to return an ok/error tuple to abide by the new behaviour api.

Note on configuration errors

We no longer raise api errors, but we do raise configuration errors. Since configuration errors do not fall under the category of email building/delivery errors, it seems fine that we raise those errors.

@germsvel germsvel mentioned this pull request Dec 28, 2020
Merged
3 tasks
@germsvel germsvel added adapter Related to supported adapters breaking Potentially breaking change labels Dec 28, 2020
@germsvel germsvel added this to the 2.0 milestone Dec 28, 2020
@lady3bean
Copy link

also failing on undefined build_api_error function, like #572 and #573. But otherwise looks good.

== Compilation error in file lib/bamboo/adapters/mandrill_adapter.ex ==
** (CompileError) lib/bamboo/adapters/mandrill_adapter.ex:44: undefined function build_api_error/3
    (elixir) src/elixir_locals.erl:107: :elixir_locals."-ensure_no_undefined_local/3-lc$^0/1-0-"/2
    (elixir) src/elixir_locals.erl:108: anonymous fn/3 in :elixir_locals.ensure_no_undefined_local/3
    (stdlib) erl_eval.erl:680: :erl_eval.do_apply/6

This was referenced Feb 18, 2021
Open
Closed
Closed
Closed
Open
Closed
Open
Closed
Closed
Closed
@germsvel
Update Mandrill to return ok/error tuples
639b8fb 
What changed?
============

Update MandrillAdapter to return an ok/error tuple to abide by the new
behaviour api.

Note on configuration errors
--------------------------

We no longer raise api errors, but we do raise configuration errors.
Since configuration errors do not fall under the category of email
building/delivery errors, it seems fine that we raise those errors.
@germsvel germsvel force-pushed the gv-mandrill-new-deliver branch from dd1d3f0 to 639b8fb Compare February 19, 2021 14:27
@germsvel germsvel changed the base branch from bamboo-2 to master February 19, 2021 14:30
@germsvel germsvel merged commit ed6cfef into master Feb 19, 2021
@germsvel germsvel deleted the gv-mandrill-new-deliver branch February 19, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
adapter Related to supported adapters breaking Potentially breaking change
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@germsvel @lady3bean