Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Relationship keys not transformed with dasherize_shallow config option #314

Closed
protestContest opened this issue Feb 22, 2024 · 0 comments · Fixed by #315
Closed

Bug: Relationship keys not transformed with dasherize_shallow config option #314

protestContest opened this issue Feb 22, 2024 · 0 comments · Fixed by #315

Comments

@protestContest
Copy link
Contributor

If the :field_transformation config option is :dasherize or :camelize, the document's attributes and relationship keys are transformed. Since :dasherize_shallow and :camelize_shallow was introduced, only the keys of the document's attributes are transformed, but not the keys of relationships.

In my view, relationship keys should also be transformed when the :dasherize_shallow or :camelize_shallow options are used.

Related to #310. I'll create a PR for this small fix.
@protestContest protestContest mentioned this issue Feb 22, 2024
Merged
mattpolzin added a commit that referenced this issue Feb 24, 2024
@protestContest @mattpolzin
Transform relationship keys with shallow field transformation options (…
00d01cf 
…#314) (#315)

* Transform relationship keys with shallow field transformation options

* bump patch version

* Add line item for other bug fix

---------

Co-authored-by: Mathew Polzin <matt.polzin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transform relationship keys with shallow field transformation options (#314) protestContest/jsonapi
1 participant
@protestContest