Expand Build Matrix #150
Expand Build Matrix #150
Conversation
Let's also trust Travis to do the right thing with respect to selecting the OTP version to use.
| @@ -27,4 +18,4 @@ sudo: false | |||
| script: | |||
| - mix test | |||
| - mix credo | |||
| - if [[ `elixir -v` = *"1.6"* ]]; then mix format --check-formatted; fi | |||
| - if [[ `elixir -v` = *"1.7"* ]]; then mix format --check-formatted; fi | |||
There was a problem hiding this comment.
Why did you change this to 1.7?
There was a problem hiding this comment.
1.7, being the latest public release (outside of 1.8-rc1), felt like the logical choice to run this particular build step on — especially since I'm adding it to the build.
There was a problem hiding this comment.
This is meant to ensure the command isn't run without formatter (versions prior to 1.5).
| - 1.6 | ||
| - 1.5 | ||
| - 1.4 | ||
|
|
||
| otp_release: |
There was a problem hiding this comment.
Can you link us to the documentation that explains why we don't need this? If you look around pretty much every Elixir project has these OTP releases defined, including Elixir itself.
There was a problem hiding this comment.
https://docs.travis-ci.com/user/languages/elixir#specifying-otp-release-version I think I'm reading this correctly...
There was a problem hiding this comment.
I believe so. As I understand it, if we leave this off, it will pick one OTP version. We are intentionally testing against multiples because it is common in real-world situations to have Elixir and OTP on different versions.
|
@jherdman I'm going to close this PR for now. None of these changes will work as expected:
Next time feel free to open an issue first to discuss changes not currently documented 👍 |
Let's also trust Travis to do the right thing with respect to selecting
the OTP version to use.