-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand build matrix #151
Expand build matrix #151
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,22 @@ | ||
language: elixir | ||
|
||
elixir: | ||
- 1.7 | ||
- 1.6 | ||
- 1.5 | ||
- 1.4 | ||
|
||
otp_release: | ||
- 20.1 | ||
- 21.1 | ||
- 20.3 | ||
- 19.3 | ||
- 18.3 | ||
|
||
matrix: | ||
exclude: | ||
- elixir: 1.6 | ||
otp_release: 18.3 | ||
- elixir: 1.5 | ||
otp_release: 21.1 | ||
|
||
env: | ||
global: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll remove sudo and push it up now 👍 |
||
|
@@ -27,4 +30,4 @@ sudo: false | |
script: | ||
- mix test | ||
- mix credo | ||
- if [[ `elixir -v` = *"1.6"* ]]; then mix format --check-formatted; fi | ||
- if ! [[ `elixir -v` = *"1.5"* ]]; then mix format --check-formatted; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add an exclusion for 1.7 and OTP < 19 here too. See https://hexdocs.pm/elixir/compatibility-and-deprecations.html#compatibility-between-elixir-and-erlang-otp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? All the tests currently pass @jherdman
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.