Allow returning responses as json. #805
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yordis
requested changes
Jul 27, 2023
Comment on lines
+36
to
+39
| * `:response_as_json` - If set to `true`, the response will be returned as a | ||
| JSON string instead of a struct. This is useful for persisting the original | ||
| response from stripe. You can use Stripe.Converter.convert_result/1 to get structs | ||
| from it. |
There was a problem hiding this comment.
Hey there, I need this myself, but instead, I want maps.
I like what you are going, but I would instead use an enum and avoid booleans.
It could be (just an idea, please share your thoughts on the naming):
@type response_as :: :map | :struct | :rawWhat do you think?
There was a problem hiding this comment.
I think this is reasonable. I will make the changes when I next get a few moments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to persist stripe information to our database for faster retrieval, I found I had written a wrapper that was decoding stripe schemas manually into json, then storing it in json, then trying to fetch the json back out into structs. When the api version changes this gets complicated due to incompatibilities (like Stripe.Discount used to exist, now it doesn't, or just in general new fields that exist or are removed).
I really could just be storing the json from stripe and then converting these back into stripe structs for my code to make use of, getting stripity stripe out of the chain.