Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry #809

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Telemetry #809

merged 1 commit into from
Sep 17, 2023

Conversation

gsychev
Copy link
Contributor

@gsychev gsychev commented Sep 5, 2023

No description provided.

@gsychev gsychev requested a review from a team as a code owner September 5, 2023 17:37
Copy link
Member

@yordis yordis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking the initiative!

I am wondering if you wouldn't following https://github.com/elixir-tesla/tesla/blob/master/lib/tesla/middleware/telemetry.ex to an extent and add [:stripe, :request, :start] [:stripe, :request, :stop] and [:stripe, :request, :exception] using telemetry:span/3 (it will require to update the :telemetry version btw)

@gsychev
Copy link
Contributor Author

gsychev commented Sep 5, 2023

@yordis I don't quite understand the request. :telemetry.span is already adding start, stop and exception

@yordis
Copy link
Member

yordis commented Sep 5, 2023

I am an idiot! 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 I just realized you did what I asked you to do 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 🤦🏻 (alright I need to rest before code reviewing things, my apologies)

@gsychev
Copy link
Contributor Author

gsychev commented Sep 6, 2023

@yordis, so what do you think about this PR?

@yordis
Copy link
Member

yordis commented Sep 6, 2023

I am in ElixirConf this week. Let me get back to you after it. Thus far looks good

@yordis yordis merged commit fea9e52 into beam-community:main Sep 17, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants