Add arm64 atomics fix script

[panpilkarz]

Add install command to Makefile, which consolidates following:

yarn install
poetry install
ape compile

and conditionally fixes atomics problem on arm64 chips.

[istankovic]

Hmmm, I feel like this should be handled by poetry.
In other words, you shouldn't need to upgrade atomics this way, but you would perhaps just need to specify --platform to poetry when doing the install. Doesn't something like that work?

[istankovic]

poetry add at least has this:

--platform=PLATFORM    Platforms for which the dependency must be installed.

so at least it looks like it's possibe to have multiple platforms supported.

[panpilkarz]

I couldn't find a way how to achieve that in poetry, but while doing more research, figured out a simpler command:

arch -arm64 pip install atomics --no-binary :all:

Would it be OK to just add it as a note to https://docs.beamerbridge.com/contributing.html?

Or perhaps add an install script, which would execute poetry install inside and conditionally execute above pip command?

[panpilkarz]

I guess having install script wrapping up yarn install and poetry install and ape compile and fixing arm64 issue would be a nice shortcut.

[istankovic]

I guess having install script wrapping up yarn install and poetry install and ape compile and fixing arm64 issue would be a nice shortcut.

Do yarn and ape need that kind of wrapper, though?
From what I understand, you only had issues with the atomics package -- everything else worked?

Personally, I'm leaning more toward a Mac-specific note in the docs, but it would also be nice to have feedback from people actually using Arm Macs. @fredo

[panpilkarz]

I meant following script (pseudo code):

yarn install
poetry install
if arm64 {
   arch -arm64 pip install atomics --no-binary :all:
}
poetry run ape compile

Then to shorten the docs with running make install instead of 3 separate commands.

[fredo]

I think here are two different features:

One is to improve the handling of the missing arm64 build wheel in atomics, and second creating a make install command which also handles yarn and compilation of contracts.

In general I'm in favor of shorter commands to get started. However, I see that the main benefit here would be the fix for atomics.
@panpilkarz Is there a particular reason why you also added the compile command into the install target?

[panpilkarz]

No real reason. Happy to get rid of it.

[istankovic]

This results in

make: arch: No such file or directory

on my machine.

[panpilkarz]

Please check now.

[istankovic]

Let's just use uname -m since that is available everywhere.

[panpilkarz]

@istankovic to follow up your concern raised on chat:

could you please take a look at python-poetry/poetry#2138 (comment) ?

I think it sucks to use a fixed url with fixed version of the package.

In my solution, "the correct" version of package will be reinstalled, the one which poetry figured out after resolving dependencies puzzle. To achieve that, after poetry install is done, the code checks for atomics version installed, and reinstalls the same version from universal2 binary.

[panpilkarz]

@istankovic Also stuff like this:

torch = [
   {markers = "sys_platform == 'linux'", url = "https://download.pytorch.org/whl/cpu/torch-1.8.1%2Bcpu-cp38-cp38-linux_x86_64.whl"},
   {markers = "sys_platform == 'darwin'", url = "https://download.pytorch.org/whl/cpu/torch-1.8.1-cp38-none-macosx_10_9_x86_64.whl"}
]

makes it possible to pin a version for a platform not for architecture. No need to patch for darwin users with Intel.

[istankovic]

I think it sucks to use a fixed url with fixed version of the package.

Yeah, I completely agree. Poetry still doesn't have a nice answer for this....

[istankovic]

Could you please squash the commits so that we end up with one commit changing only the Makefile, and another for the docs?

[istankovic]

Nitpick: egrep is deprecated (not sure about the version you have on Mac, though)

egrep: warning: egrep is obsolescent; using grep -E

[panpilkarz]

you're right. used grep -E in difflint work for that reason.

[istankovic]

Looks good!