Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure conda execution is enabled in configuration #5

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

cpauvert
Copy link
Contributor

@cpauvert cpauvert commented Jul 5, 2024

Hi,
Here's a tentative PR for #4, but in the issue I was misleading in trying to change how the command line for nextflow was called, when in fact, the key was in the configuration file.

I ensure that conda is enabled as per https://www.nextflow.io/docs/stable/config.html#config-conda

Let me know if you prefer edits to be made differently.
Best,

@cpauvert
Copy link
Contributor Author

cpauvert commented Jul 8, 2024

It seems the issue for the checks is about the rate limit for codecov.

There was an error fetching the storage URL during POST
ErrorDetail(string='Rate limit reached. Please upload with 
the Codecov repository upload token to resolve issue.

The code coverage report seems to be correctly generated in the ubuntu image but I do not know how to fetch this report. Any suggestions?

BEst,

@beardymcjohnface
Copy link
Owner

Yeah, I had this issue with another repo of mine. Let me push an update real quick.

@beardymcjohnface
Copy link
Owner

Hi @cpauvert can you update your PR branch please?

@cpauvert
Copy link
Contributor Author

cpauvert commented Jul 8, 2024

Hi @cpauvert can you update your PR branch please?

Yep, done! Thanks for the fix

@beardymcjohnface beardymcjohnface merged commit 3da98f7 into beardymcjohnface:main Jul 8, 2024
7 checks passed
@beardymcjohnface
Copy link
Owner

Awesome, thanks!

@cpauvert cpauvert deleted the fix-4-with-conda branch July 8, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants