-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Construct 2.8.8 to 2.10.68 (All tests pass on 3.10) #24
base: master
Are you sure you want to change the base?
Commits on Apr 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7befcd2 - Browse repository at this point
Copy the full SHA 7befcd2View commit details -
Replace String with PaddedString
When construct replaced String with PaddedString, the return type changed from bytes to unicode strings (u"..." on Python 2, "..." on Python 3). This affects a lot of conditional checks, tests, and user code. For example box type definitions. I've updated the code to reflect this change.
Configuration menu - View commit details
-
Copy full SHA for b712d1e - Browse repository at this point
Copy the full SHA b712d1eView commit details -
Flip argument order on all uses of Const
For some reason sometime between 2.8.8 and 2.8.22 the arguments for Const were flipped.
Configuration menu - View commit details
-
Copy full SHA for 4e4a481 - Browse repository at this point
Copy the full SHA 4e4a481View commit details -
Replace PrefixedIncludingSize with Prefixed with includelength=True
The includelength parameter was added in `2.8.11`. Also removes TellMinusSizeOf as it's now unused.
Configuration menu - View commit details
-
Copy full SHA for 56bf14d - Browse repository at this point
Copy the full SHA 56bf14dView commit details -
Strings now require explicit specification of encoding
The default for CString and PascalString was previously "ascii" (from what I can tell) so I specified "ascii" for everything that did not explicitly specify an encoding.
Configuration menu - View commit details
-
Copy full SHA for 04e725a - Browse repository at this point
Copy the full SHA 04e725aView commit details -
Simplify Container builds in tests
Construct 2.10 (maybe even 2.9) no longer allows you to do e.g., `Container(foo=1)(bar=2)` as an alternative to `Container(foo=1, bar=2)` and I honestly can't blame them, it makes the code extremely annoying to read and undoubtably to parse as well. This commit simplifies them to singular construct call under a single Container object.
Configuration menu - View commit details
-
Copy full SHA for f24c826 - Browse repository at this point
Copy the full SHA f24c826View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cf4166 - Browse repository at this point
Copy the full SHA 2cf4166View commit details -
Configuration menu - View commit details
-
Copy full SHA for c67c0ba - Browse repository at this point
Copy the full SHA c67c0baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 70f805a - Browse repository at this point
Copy the full SHA 70f805aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0506105 - Browse repository at this point
Copy the full SHA 0506105View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2d87c7 - Browse repository at this point
Copy the full SHA c2d87c7View commit details -
Rework ISO6392TLanguageCode Adapter to expect Int16 data
This way we don't have to use BitStruct and messy embedding/nesting decisions and can directly nest the language.
Configuration menu - View commit details
-
Copy full SHA for 7b6c1d7 - Browse repository at this point
Copy the full SHA 7b6c1d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2858709 - Browse repository at this point
Copy the full SHA 2858709View commit details -
Remove types from each individual box struct
This removes duplicate checks and duplicate output data.
Configuration menu - View commit details
-
Copy full SHA for da2cf3c - Browse repository at this point
Copy the full SHA da2cf3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8262cce - Browse repository at this point
Copy the full SHA 8262cceView commit details -
Replace use of Embedded with nested "data" field
This is by no means ideal. It would be much preferred to be embedded, but the maintainer of construct has stated there is no workaround and nesting is the only option. This means when building boxes we must now nest the data in `data` container. This also means grabbing a fields value must now specify `.data` first, e.g., `tenc_box.data.is_encrypted`. See changes with the tests. Not ideal at all.
Configuration menu - View commit details
-
Copy full SHA for d81c932 - Browse repository at this point
Copy the full SHA d81c932View commit details
Commits on Aug 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 09a5b85 - Browse repository at this point
Copy the full SHA 09a5b85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33dc5d6 - Browse repository at this point
Copy the full SHA 33dc5d6View commit details