Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Construct 2.8.8 to 2.10.68 (All tests pass on 3.10) #24

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Commits on Apr 17, 2023

  1. Configuration menu
    Copy the full SHA
    7befcd2 View commit details
    Browse the repository at this point in the history
  2. Replace String with PaddedString

    When construct replaced String with PaddedString, the return type changed from bytes to unicode strings (u"..." on Python 2, "..." on Python 3).
    
    This affects a lot of conditional checks, tests, and user code. For example box type definitions.
    
    I've updated the code to reflect this change.
    rlaphoenix committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    b712d1e View commit details
    Browse the repository at this point in the history
  3. Flip argument order on all uses of Const

    For some reason sometime between 2.8.8 and 2.8.22 the arguments for Const were flipped.
    rlaphoenix committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    4e4a481 View commit details
    Browse the repository at this point in the history
  4. Replace PrefixedIncludingSize with Prefixed with includelength=True

    The includelength parameter was added in `2.8.11`. Also removes TellMinusSizeOf as it's now unused.
    rlaphoenix committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    56bf14d View commit details
    Browse the repository at this point in the history
  5. Strings now require explicit specification of encoding

    The default for CString and PascalString was previously "ascii" (from what I can tell) so I specified "ascii" for everything that did not explicitly specify an encoding.
    rlaphoenix committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    04e725a View commit details
    Browse the repository at this point in the history
  6. Simplify Container builds in tests

    Construct 2.10 (maybe even 2.9) no longer allows you to do e.g., `Container(foo=1)(bar=2)` as an alternative to `Container(foo=1, bar=2)` and I honestly can't blame them, it makes the code extremely annoying to read and undoubtably to parse as well.
    
    This commit simplifies them to singular construct call under a single Container object.
    rlaphoenix committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    f24c826 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2cf4166 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c67c0ba View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    70f805a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0506105 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c2d87c7 View commit details
    Browse the repository at this point in the history
  12. Rework ISO6392TLanguageCode Adapter to expect Int16 data

    This way we don't have to use BitStruct and messy embedding/nesting decisions and can directly nest the language.
    rlaphoenix committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    7b6c1d7 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2858709 View commit details
    Browse the repository at this point in the history
  14. Remove types from each individual box struct

    This removes duplicate checks and duplicate output data.
    rlaphoenix committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    da2cf3c View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    8262cce View commit details
    Browse the repository at this point in the history
  16. Replace use of Embedded with nested "data" field

    This is by no means ideal. It would be much preferred to be embedded, but the maintainer of construct has stated there is no workaround and nesting is the only option.
    
    This means when building boxes we must now nest the data in `data` container. This also means grabbing a fields value must now specify `.data` first, e.g., `tenc_box.data.is_encrypted`. See changes with the tests. Not ideal at all.
    rlaphoenix committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    d81c932 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Configuration menu
    Copy the full SHA
    09a5b85 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    33dc5d6 View commit details
    Browse the repository at this point in the history