Correctly define _reserved1 in tenc box and improve it's Const checks #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlaphoenix
force-pushed
the
tenc-box-patch
branch
2 times, most recently
from
42446d4
to
56cb3da
Compare
rlaphoenix
force-pushed
the
tenc-box-patch
branch
from
56cb3da
to
d487986
Compare
rlaphoenix
force-pushed
the
tenc-box-patch
branch
from
d487986
to
edb9347
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
=========================================
Coverage ? 74.61%
=========================================
Files ? 5
Lines ? 197
Branches ? 0
=========================================
Hits ? 147
Misses ? 50
Partials ? 0
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You defined _reserved1 as a Const byte, when in fact it's not. For v0 tenc boxes, it is. But not for v1 tenc boxes which use pattern-based decision-making for the Key ID and IV stuff. Therefore I've implemented the necessary changes to fully support v1 tenc boxes.
This fixes #29
Tests are successful (on Python 3.9 and older, see #23).