This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
Integration fixes #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #7 there were still some issues with the integration testing, and I ended up having to do a lot of digging along with trial and error to figure out how Github Actions does certain things (especially when running jobs in containers).
There were some other items that also added to the mix - mainly that in trying to make the images smaller (they were >1GB previously) by using the
slimpython images I discovered thatpoetryrequiresgitto be installed in order to install this project from git after merging PRs. I investigated some other approaches such as using actions to build a wheel locally, but that does not allow for installing extras it seems. Ultimately I had to manually add git to the dockerfiles.There was one main net positive result from all of this, and that was when I finally was able to run the integration tests, they exposed that
typing-extensionswas not being installed in 3.7 and 3.8 as it was not explicitly listed as a dependency. This has also been fixed as part of this PR which adds it as a conditional dependency for python versions< 3.9.(Note that the most recent manual invoke of the integration job still fails as the job itself references the main branch and does not have the fix)