Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis support #78

Merged
merged 8 commits into from
Apr 9, 2021
Merged

Redis support #78

merged 8 commits into from
Apr 9, 2021

Conversation

mantzas
Copy link
Contributor

@mantzas mantzas commented Apr 7, 2021 •
edited
Loading

Which problem is this PR solving?

Closes #79.

Short description of the changes

  • Introduce a getter
  • Introduce a watcher
  • Introduce new struct tag
  • Add new methods to the builder
  • Improved test coverage

@mantzas mantzas marked this pull request as ready for review April 8, 2021 17:50
c0nstantx
c0nstantx reviewed Apr 9, 2021
View reviewed changes
Copy link
Contributor

@c0nstantx c0nstantx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition.
Can you squash commits with same name, please ?

@mantzas
Copy link
Contributor Author

mantzas commented Apr 9, 2021

Nice addition.
Can you squash commits with same name, please ?

Is this blocking your CR? The end result should matter in the end everything will be squashed and merged to master in one commit!

@c0nstantx
Copy link
Contributor

c0nstantx commented Apr 9, 2021 •
edited
Loading

Is this blocking your CR? The end result should matter in the end everything will be squashed and merged to master in one commit!

No. It's not blocking. It's the only comment I had.
I didn't know that we have a "Squash and Merge" policy on this repo. Could you please add it to the contribution guidelines ?

Personally I prefer "Rebase and Merge" for open source projects so that the commit log on master branch is more clear.

Thanks.

Lazaros-Tsigkakos
Lazaros-Tsigkakos approved these changes Apr 9, 2021
View reviewed changes
Copy link

@Lazaros-Tsigkakos Lazaros-Tsigkakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition indeed. LGTM, Sotiris.

log/consul_test.go
assert.Empty(t, buf.String())
buf.Reset()
logger.Log(hclog.Trace, "123")
assert.Contains(t, buf.String(), "DEBUG: 123")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "TRACE: 123" instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the consul logger and funny enough trace reports DEBUG. The test is passing.

@mantzas mantzas merged commit 59dbdfe into master Apr 9, 2021
@mantzas mantzas deleted the redis-support branch April 9, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lazaros-Tsigkakos Lazaros-Tsigkakos Lazaros-Tsigkakos approved these changes

@c0nstantx c0nstantx c0nstantx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redis support
3 participants
@mantzas @c0nstantx @Lazaros-Tsigkakos