Use redis universal client instead of a concrete type #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberonus
requested review from
c0nstantx,
Lazaros-Tsigkakos and
mantzas
as code owners
Lazaros-Tsigkakos
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Current implementation of the redis seeder/watcher requires a concrete implementation of the redis client. It does not allow developers to use other clients, e.g.
ClusterClientorSentinelClient.To resolve this limitation, the library should consume and use internally existing
redis.UniversalClientinterface abstraction.Short description of the changes
Replaces concrete redis client struct with interface.