-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Kafka Consumer Package #342
Conversation
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
==========================================
+ Coverage 72.66% 73.50% +0.84%
==========================================
Files 71 74 +3
Lines 3859 4077 +218
==========================================
+ Hits 2804 2997 +193
- Misses 941 963 +22
- Partials 114 117 +3
Continue to review full report at Codecov.
|
c59249b
to
ee09855
Compare
Signed-off-by: oss92 <mohamed.o.alnagdy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I am eager to start to use it. Very nice work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is solid work, thanks! Looking forward to use it
I tried to think how to make some loops simpler but could not think of anything better.
🥇
c90d1b3
to
88cfbfc
Compare
88cfbfc
to
46882bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 nice work! Looking forward to toying with it!
Which problem is this PR solving?
Closes #260
Short description of the changes
We've had a few discussions about the best way to move forward with the task; the key outcomes were
Checklist