Add tests for meta on resource objects.

[rafael]

@beauby what do you think about this as starting point? Are there any other tests that you think we should add? Do you think adding a new file is ok or is it a better place for these tests to live?

TODO:

• Add serializer-level tests (testing ActiveModel::Serializer.meta and ActiveModel::Serializer#meta)
• Adapt current test to make use of the object itself (in order to showcase the power of blocks over direct params)
• Add test to make use of direct parameters

[beauby]

@rafael Thanks a lot! I think there should be tests in test/serializers/meta_test.rb (which already exists), that would just make sure the serializer-level logic works with blocks and hashes, and in test/adapter/json_api/resource_meta_test.rb which you created.

[beauby]

Would be great to make a test using the block syntax (like here) to make use of some of object's property, like

meta do
  { comments_count: object.comments.count }
end

and an other test that makes use of the direct syntax (no bloc) as follows:

meta { stuff: 'value' }

Detail: use single quotes for strings without interpolation, otherwise Rubocop will complain when we try to merge it.

[beauby]

When those are taken care of, I'll be happy to merge your commit in my branch, and then get the branch merged into master!

[rafael]

Cool! Thanks for the feedback.

Will make this changes and update the PR.

[rafael]

@beauby . I was not 100% I got what you meant with the serializer-level tests. I added some. Do they look good to you ?

[gaganawhad]

@beauby I took a look at this, I am not sure I follow what the serializer-level test is either. Great job here @rafael

[rafael]

@beauby did you have a chance to review the tests ? Do they look good to merge?

[beauby]

@rafael Can't really review it right now but it looks good so I'm merging those into my branch and we'll ask people to review it on rails-api/AMS.

[gaganawhad]

Awesome! Thanks guys!