Fix npmignore #1251
Fix npmignore #1251
Conversation
This fixes the npmignore to also add a rule to exclude the children in js/ from being ignored, so that they will be added when npm packs the package.
|
My bad sorry! Thanks for fixing it |
|
No problem, these things happen. 👍 |
|
@simondel @bitwiseman To fix the internet (by merging this PR and republishing), this needs an approval review from someone with write access |
|
@ob1 @bitwiseman So, any idea who would have permissions to merge PR's? |
|
@simondel from what I can see it looks like only @bitwiseman can merge (although I could be mistaken). If I'm right, this probably won't get looked at for a while at it's 5am in Seattle. |
|
isn't this a pure liability - that in a project with 5k stars, which so many depend on, only one person has write access? I can literally feel how everyone is keeping their fingers crossed that @bitwiseman doesn't have a hangover :), or his broadband cut off, or, or, or. |
|
@andreineculau , you are right, its like the leftpad story, just by accident this time! |
|
Hmm, wonder how the Travis and Appveyor builds still completed without any errors. Is it a specific version of node and/or npm where it fails? |
|
@bitwiseman: I locally bumped the package.json version to 1.7.1 and published it (with these changes) to unblock folks, so you'll need to update that in the source, too. |
.npmignore
Outdated
| !js/ | ||
| !js/**/* | ||
| !CONTRIBUTING.MD |
There was a problem hiding this comment.
Not sure if we really need js/test/** included in the published artifact, but it only adds ~50kb so I didn't bother re-ignoring it.
|
@evocateur You beat me to publishing by about 1 minute. I've published 1.7.2 that also reverts. |
|
@maael - Thanks for providing the fix. I've updated it with an additional admonition. 😄 |
|
@bitwiseman You da man! |
This fixes the npmignore to also add a rule to exclude the children in js/ from being ignored, so that they will be added when npm packs the package.
.npmignoreis based on the same rules as.gitignore, meaning!js/will only exclude the immediate children injs/, not any others. This just adds a glob of!js/**/*to include the children, and the files needed for installing this package.Fixes #1247.