-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added space_in_paren to the CSS options #1857
base: main
Are you sure you want to change the base?
Conversation
The default value is false to keep the current behaviour as-is Added both JS and Py implementations Added unit tests for the space_in_paren option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
Additional testing needed.
You might also try using a matrix
config for the test. That way you can can supply a few inputs and generate the expected outputs like in the example below.
fragment: true, | ||
input: [ | ||
'a {', | ||
'width: min(100%,100vw);', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add another test where the input has multiple spaces in inside the paren, example: 'width: min(. 100%. , 100vw. );',
. In the case the extra spaces should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! Will add them in the coming week.
@ninio Do you have time to update this? |
The default value is false to keep the current behaviour as-is
Added both JS and Py implementations
Added unit tests for the space_in_paren option
Description
master
)Fixes #1856
Before Merge Checklist
These items can be completed after PR is created.
(Check any items that are not applicable (NA) for this PR)