Capture empty tags

[JuanFML]

Description

Updated xml to capture empty tags in both python and JS files

• Source branch in your fork has meaningful name (not master)

Fixes Issue: #1854

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (NA) for this PR)

• JavaScript implementation
• Python implementation (NA if HTML beautifier)
• Added Tests to data file(s)
• Added command-line option(s) (NA if
• README.md documents new feature/option(s)

[bitwiseman]

Very nice change.

[bitwiseman]

This needs to be empty to actually test your change right?

Suggested change

	' <a>',
	' <td>Hello</td>',
	' <td>World</td>',
	' </a>',
	' <>',
	' <td>Hello</td>',
	' <td>World</td>',
	' </>',

[JuanFML]

Oh! I didn't see I hadn't changed it back, I will change this now

[bitwiseman]

I think it is clearer to say this group is optional, but that might cause the number groups to change, right?

This is not a suggestion, I'm just using that to show a clear diff.

Suggested change

	xml: pattern_reader.matching(/[\s\S]*?<(\/?)([-a-zA-Z:0-9_.]+|{[\s\S]+?}|!\[CDATA\[[\s\S]*?\]\]|)(\s+{[\s\S]+?}|\s+[-a-zA-Z:0-9_.]+|\s+[-a-zA-Z:0-9_.]+\s*=\s*('[^']*'|"[^"]*"|{[\s\S]+?}))*\s*(\/?)\s*>/),
	xml: pattern_reader.matching(/[\s\S]*?<(\/?)([-a-zA-Z:0-9_.]+|{[\s\S]+?}|!\[CDATA\[[\s\S]*?\]\])?(\s+{[\s\S]+?}|\s+[-a-zA-Z:0-9_.]+|\s+[-a-zA-Z:0-9_.]+\s*=\s*('[^']*'|"[^"]*"|{[\s\S]+?}))*\s*(\/?)\s*>/),

[JuanFML]

Oh I see what you mean, but yes it causes other problems

[JuanFML]

While fixing this issue I saw something that could be another issue:
In https://beautifier.io/ whenever you try to beautify a code with an indent of 2 spaces to an indent with 4 spaces it is unable to beautify it correctly:
Input: (with predefined options only with Support e4x/jsx syntax selected)

class Columns extends React.Component {
  render() {
    return (
      <t>        
        <td>Hello</td>
        <td>World</td>
      </t>
    );
  }
}

Output:

class Columns extends React.Component {
    render() {
        return (
            <t>        
        <td>Hello</td>
        <td>World</td>
      </t>
        );
    }
}

Although if I changed to indent to 2 spaces per indent, the output would be unchanged from the first input which is the expected output. This is because the input is tabbed with 2 spaces. Maybe the error is because of the single tags, although I haven't looked into it yet

[bitwiseman]

@JuanFML
Yes, you're seeing #665.

[JuanFML]

@JuanFML
Yes, you're seeing #665.

Oh yes that it is what I encounter, I see now it was already reported

[Zetrick]

I am still having the issue of empty <> </> tags in my jsx being incorrectly formatted. Do I need to change something manually, or add another setting to the .jsbeautifyrc file to incorporate this change?

Before format:

<>
    <ExampleComponentA />
    <ExampleComponentB />
</>

After format:

<>
    <ExampleComponentA /> <
ExampleComponentB / >
<
/>

[bitwiseman]

@Zetrick
Not sure. have your tried this on https://beautifier.io ? Looks good to me there.