Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding #1951

Merged
merged 22 commits into from Nov 1, 2021
Merged

Branding #1951

merged 22 commits into from Nov 1, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 2, 2021

Description

  • Source branch in your fork has meaningful name (not main)

This pull adds branding assets for the js-beautifier repository.

Fixes Issue: #1936

Images

Old

New

website screenshot

light banner dark banner

light wordmark dark wordmark

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (N/A) for this PR)

  • JavaScript implementation
  • Python implementation (N/A if HTML beautifier)
  • Added Tests to data file(s)
  • Added command-line option(s) (N/A if
  • README.md documents new feature/option(s)

@bitwiseman
Copy link
Member

@4086606
Thanks for doing this. It looks really good.
I have a mild concern, which is that the beautifier is actually not just JS. The website is https://beautifier.io/ and it currently also works on CSS and HTML. So, the JS is a bit misleading.

On the other hand, "js-beautify" is the name of the project - the repo, the npm package.

Would you be willing to do something in this style, yellow and grey lines of a flower, like the tulip icon: 🌷
If not, that's fine, it is better to has some logo rather than none and change it later if needed.

Thanks again.

@ghost
Copy link
Author

ghost commented Jul 6, 2021

Would love to go in a different direction than the current one.
A flower drawn in lines is a great and unique idea, I'll look into it tomorrow 😪

@ghost
Copy link
Author

ghost commented Jul 15, 2021

@bitwiseman how does #1951 (comment) look now?

@bitwiseman
Copy link
Member

I like it!

@bitwiseman
Copy link
Member

@4086606 This is looks great but I need to fix the CI build to merge it. Thanks for your patience.

@ghost
Copy link
Author

ghost commented Aug 27, 2021

Find any time to work on it in the summer? No hurry, no worries 😃

@kayal28
Copy link

kayal28 commented Sep 10, 2021

Description

  • Source branch in your fork has meaningful name (not main)

This pull adds branding assets for the js-beautifier repository.

Fixes Issue: #1936

Images

icon icon

website screenshot

light banner dark banner

light wordmark dark wordmark

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (N/A) for this PR)

  • JavaScript implementation
  • Python implementation (N/A if HTML beautifier)
  • Added Tests to data file(s)
  • Added command-line option(s) (N/A if
  • README.md documents new feature/option(s)

@ghost
Copy link
Author

ghost commented Oct 29, 2021

Nice! Just got the CI notif

@bitwiseman bitwiseman merged commit a481700 into beautifier:main Nov 1, 2021
@ghost ghost deleted the branding branch November 1, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants