-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async function should stay on the same line #634
Conversation
I've never used python, so I don't know why the build is failing. |
The build is failing because you're editing the test files directly. Edit the 'test/data/javascript.js' file. Then run
|
Other than that, your change works seems reasonable, but needs some more tests. |
No worries. I'll revert those files back and put the tests into the proper place. |
Those files will still end up being modified, but they'll be modified by the build. :) |
make testj doesnt seem to work on my machine (Windows 8 x64) it gives me
However I was able to Python is still giving me an issue though
Although I didn't touch that file at all. |
@@ -616,6 +616,10 @@ def handle_start_expr(self, current_token): | |||
# TODO: option space_before_conditional | |||
self.output.space_before_token = True | |||
|
|||
elif current_token.text == '(' && self.last_type == 'TK_RESERVED' && self.flags.last_word == 'await') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's why the python is breaking. This line should look like this:
elif current_token.text == '(' and self.last_type == 'TK_RESERVED' and self.flags.last_word == 'await':
I'll get it.
👍 |
For this windows build error, could you file that as an issue? We don't get much coverage on windows. |
woohoo ! |
I'm going to flatten this into a single commit and push the change directly. |
I haven't quite figured out how to do that yet. Time for some more learning. |
It's worth learning, but I've got it for this one. Good job on this and with the tests as well. |
Deals with #630
Sorry about the messy commit. It looks like the code got beautified and removed the tabs that were there.
I haven't figured out how to squash these commits into one yet, but if you really want I can go figure it out.