Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP8 support. #302

Merged
merged 3 commits into from
Nov 12, 2020
Merged

Add PHP8 support. #302

merged 3 commits into from
Nov 12, 2020

Conversation

ptondereau
Copy link
Contributor

@ptondereau ptondereau commented Oct 5, 2020 •
edited
Loading

  • Added php7.4 in matrix
  • Add config for php nightly aka 8.0
  • Fix tests

@ptondereau ptondereau force-pushed the php8 branch 2 times, most recently from 72443a2 to e116c09 Compare October 5, 2020 18:54
@ptondereau ptondereau marked this pull request as ready for review October 5, 2020 19:05
@ptondereau ptondereau mentioned this pull request Oct 5, 2020
Closed
@ptondereau
Copy link
Contributor Author

@villfa here you go

@ptondereau ptondereau mentioned this pull request Oct 5, 2020
Closed
@ptondereau @villfa
Update tests/Assert/Tests/AssertTest.php
5c4dd23 
Co-authored-by: Fabien Villepinte <fabien.villepinte@gmail.com>
@villfa
Copy link
Contributor

villfa commented Nov 1, 2020

@rquadling would you have time to review this PR?
Thanks in advance

@greg0ire greg0ire mentioned this pull request Nov 12, 2020
Closed
@beberlei beberlei merged commit c61e82d into beberlei:master Nov 12, 2020
@ptondereau ptondereau deleted the php8 branch November 12, 2020 22:27
@martinssipenko
Copy link

@beberlei can we expect a release any time soon?

@phil-davis
Copy link

Note: https://github.com/beberlei/assert/releases/tag/v3.3.0 should have PHP 8.0 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villfa villfa villfa left review comments

@ausi ausi ausi approved these changes

@beberlei beberlei beberlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ptondereau @villfa @martinssipenko @phil-davis @beberlei @ausi