[doctrineGH-4019] Trigger deprecations for fetch mode deprecation to …

…fetch* APIs.

composer.json

@@ -35,6 +35,7 @@
  "php": "^7.3 || ^8",
  "ext-pdo": "*",
  "doctrine/cache": "^1.0",
+ "doctrine/deprecations": "^0.2.0",
  "doctrine/event-manager": "^1.0"
  },
  "require-dev": {

lib/Doctrine/DBAL/Connection.php

@@ -21,6 +21,7 @@
 use Doctrine\DBAL\Query\QueryBuilder;
 use Doctrine\DBAL\Schema\AbstractSchemaManager;
 use Doctrine\DBAL\Types\Type;
+use Doctrine\Deprecations\Deprecation;
 use Throwable;
 use Traversable;
 
@@ -542,6 +543,12 @@ public function setAutoCommit($autoCommit)
  */
  public function setFetchMode($fetchMode)
  {
+ Deprecation::trigger(
+ 'doctrine/dbal',
+ 'https://github.com/doctrine/dbal/pull/4019',
+ 'Default Fetch Mode configuration is deprecated, use explicit Connection::fetch*() APIs instead.'
+ );
+
  $this->defaultFetchMode = $fetchMode;
  }
 
@@ -561,6 +568,12 @@ public function setFetchMode($fetchMode)
  */
  public function fetchAssoc($sql, array $params = [], array $types = [])
  {
+ Deprecation::trigger(
+ 'doctrine/dbal',
+ 'https://github.com/doctrine/dbal/pull/4019',
+ 'Connection::fetchAssoc() is deprecated, use Connection::fetchAssociative() API instead.'
+ );
+
  return $this->executeQuery($sql, $params, $types)->fetch(FetchMode::ASSOCIATIVE);
  }
 
@@ -578,6 +591,12 @@ public function fetchAssoc($sql, array $params = [], array $types = [])
  */
  public function fetchArray($sql, array $params = [], array $types = [])
  {
+ Deprecation::trigger(
+ 'doctrine/dbal',
+ 'https://github.com/doctrine/dbal/pull/4019',
+ 'Connection::fetchArray() is deprecated, use Connection::fetchNumeric() API instead.'
+ );
+
  return $this->executeQuery($sql, $params, $types)->fetch(FetchMode::NUMERIC);
  }
 
@@ -598,6 +617,12 @@ public function fetchArray($sql, array $params = [], array $types = [])
  */
  public function fetchColumn($sql, array $params = [], $column = 0, array $types = [])
  {
+ Deprecation::trigger(
+ 'doctrine/dbal',
+ 'https://github.com/doctrine/dbal/pull/4019',
+ 'Connection::fetchColumn() is deprecated, use Connection::fetchOne() API instead.'
+ );
+
  return $this->executeQuery($sql, $params, $types)->fetchColumn($column);
  }
 

lib/Doctrine/DBAL/Statement.php

@@ -8,6 +8,7 @@
 use Doctrine\DBAL\Exception\NoKeyValue;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Types\Type;
+use Doctrine\Deprecations\Deprecation;
 use IteratorAggregate;
 use PDO;
 use PDOStatement;
@@ -231,6 +232,12 @@ public function errorInfo()
  */
  public function setFetchMode($fetchMode, $arg2 = null, $arg3 = null)
  {
+ Deprecation::trigger(
+ 'doctrine/dbal',
+ 'https://github.com/doctrine/dbal/pull/4019',
+ 'Statement::setFetchMode() is deprecated, use explicit Statement::fetch*() APIs instead.'
+ );
+
  if ($arg2 === null) {
  return $this->stmt->setFetchMode($fetchMode);
  }
@@ -251,6 +258,13 @@ public function setFetchMode($fetchMode, $arg2 = null, $arg3 = null)
  */
  public function getIterator()
  {
+ Deprecation::trigger(
+ 'doctrine/dbal',
+ 'https://github.com/doctrine/dbal/pull/4019',
+ 'Statement::getIterator() is deprecated, use Statement::iterateNumeric(), iterateAssociative() ' .
+ 'or iterateColumn() instead.'
+ );
+
  return $this->stmt;
  }
 
@@ -261,6 +275,12 @@ public function getIterator()
  */
  public function fetch($fetchMode = null, $cursorOrientation = PDO::FETCH_ORI_NEXT, $cursorOffset = 0)
  {
+ Deprecation::trigger(
+ 'doctrine/dbal',
+ 'https://github.com/doctrine/dbal/pull/4019',
+ 'Statement::fetch() is deprecated, use Statement::fetchNumeric(), fetchAssociative() or fetchOne() instead.'
+ );
+
  return $this->stmt->fetch($fetchMode);
  }
 
@@ -271,6 +291,13 @@ public function fetch($fetchMode = null, $cursorOrientation = PDO::FETCH_ORI_NEX
  */
  public function fetchAll($fetchMode = null, $fetchArgument = null, $ctorArgs = null)
  {
+ Deprecation::trigger(
+ 'doctrine/dbal',
+ 'https://github.com/doctrine/dbal/pull/4019',
+ 'Statement::fetchAll() is deprecated, use Statement::fetchAllNumeric(), fetchAllAssociative() or ' .
+ 'fetchFirstColumn() instead.'
+ );
+
  if ($ctorArgs !== null) {
  return $this->stmt->fetchAll($fetchMode, $fetchArgument, $ctorArgs);
  }
@@ -289,6 +316,12 @@ public function fetchAll($fetchMode = null, $fetchArgument = null, $ctorArgs = n
  */
  public function fetchColumn($columnIndex = 0)
  {
+ Deprecation::trigger(
+ 'doctrine/dbal',
+ 'https://github.com/doctrine/dbal/pull/4019',
+ 'Statement::fetchColumn() is deprecated, use Statement::fetchOne() instead.'
+ );
+
  return $this->stmt->fetchColumn($columnIndex);
  }