Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata Feature Implementation #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

satyamakgec
Copy link

No description provided.

@satyamakgec satyamakgec requested a review from bebner as a code owner January 25, 2022 13:08
Copy link

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good so far! Thanks for adding this! 😃


pub fun main(addr: Address): {UInt64: DappyContract.Template} {
pub struct DappyDetails {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to make defined in the contract instead of in a script?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has no use in the contract as the data structure but can define in the contract as well, But I think it will just eat space besides making the system better,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't have use in the contract necessarily, but it might be more useful to have it centrally defined instead of having to define it in every script. For cryptodappy, it doesn't really matter because it isn't a production level contract that will actually be in use in the real world, but might be a good practice in smart contracts in general. But if you don't think it should be included in the contract, then I'll defer to you.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree with you that it is good to have it in the smart contract for the production-grade system so everyone can use that data structure.

@joshuahannan
Copy link

@bebner What do you think about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants