Fix terminal coloring issues #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couldn't figure out why amigo seemed to be broken. I saw nothing when executing "amigo <projectname>". After looking through the code I realized it was because it is coloring the prompts black and I had a dark themed terminal theme. This fix makes it work on all terminal types.
|
Hi, thanks for contribution. Actually the intention was to have the system texts in grey. But as I can see when grey color is main color in console, something went wrong. Personally, I am not so happy with this inversion style and would ask you to try use the 'grey' color from colors lib with your terminal. So in fact replace console.log(text.inverse) to console.log(text.grey). Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is what I was getting when I ran the initial
amigocommand.This is happening because the lib doesn't account for dark terminal backgrounds. Here is the result of the fix described in this PR.