Skip to content

Conversation

danielobiri
Copy link

No description provided.

Open Source Bot and others added 30 commits August 23, 2022 11:06
Summary:
GitHub commits:

facebook/fbthrift@d184f6c
facebook/litho@c866282
facebookincubator/velox@98a2c36

Reviewed By: zpao

fbshipit-source-id: 81bcc5a220a28c442f9e54d9d0a5e7b0a5ffb150
…itor

Summary:
This diff has been automatically generated by the inpage editor.
                        If you want to update this diff, go through the preview link that would be attached to the test plan.
                        Please ensure you are editing the same page that was used to create this diff.

Reviewed By: therealgymmy

Differential Revision: D38958604

fbshipit-source-id: af5b72664dfe56464e59b896cd29473b758f8021
Summary:
GitHub commits:

facebook@2eda5e4
facebook/fb303@b9801e1
facebook/fbthrift@6918860
facebook/watchman@78cf88e
facebookexperimental/rust-shed@ca8d3a5

Reviewed By: zpao

fbshipit-source-id: bc16063d175cccbe817bb65bb928f14d15b43bfd
Summary: I found a few users improperly passed `ttlSecs` as the 3rd parameter inside `insertOrReplace` API. Throw exception to avoid this.

Reviewed By: therealgymmy

Differential Revision: D38960198

fbshipit-source-id: 337819487eac83aa12cd2371da728e3f984998ab
Summary:
GitHub commits:

facebook@e2e2e00
facebook/fb303@bf47b75
facebook/fbthrift@3b79333
facebook/watchman@27791cc
facebookexperimental/rust-shed@c78af95

Reviewed By: zpao

fbshipit-source-id: 9926940a6375d6cdd7770b19673c9f80c86bd560
Summary:
GitHub commits:

facebook@8118866
facebook/fb303@63e5773
facebook/fbthrift@c127159
facebook/watchman@dce5c01
facebookexperimental/rust-shed@88af8c8

Reviewed By: zpao

fbshipit-source-id: 7ca490b118c72dc4642edcd294ed384ecb862e13
Summary:
GitHub commits:

facebook/fbthrift@e795837

Reviewed By: zpao

fbshipit-source-id: 5596f3b4d27c514c15c615f83d471a66a80844de
Summary:
GitHub commits:

facebook/fbthrift@1e2c611
facebookarchive/profilo@befd6ae

Reviewed By: zpao

fbshipit-source-id: 1e6d60daa672ac5213510fe0d99f7ed071c85001
Summary:
GitHub commits:

facebook/fbthrift@a3fe0f1

Reviewed By: zpao

fbshipit-source-id: 207d5e36e99a8b686a444a38a88449327f717036
Summary:
GitHub commits:

facebook/fbthrift@35478e7
facebook/litho@20d1c9e

Reviewed By: zpao

fbshipit-source-id: 4046d0887f0522916b588b2d0c4274a7710654dc
Summary:
GitHub commits:

facebook/folly@05b1dc5

Reviewed By: zpao

fbshipit-source-id: 5085b6b37522dac4142059011f3f4254653932fd
Summary:
AdRanker ASAN canary flagged a possible UBSan violation.

## Error
Failed Run: https://fburl.com/servicelab/apytosry
```
    #0 0x562e3adb59bc in facebook::cachelib::objcache2::ObjectCacheSizeController<facebook::cachelib::CacheAllocator<facebook::cachelib::LruCacheTrait> >::work() buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h
    #1 0x562de7610f78 in facebook::cachelib::PeriodicWorker::loop() fbcode/cachelib/common/PeriodicWorker.cpp:55
    becsedi#2 0x7f7632c524e4 in execute_native_thread_routine /home/engshare/third-party2/libgcc/11.x/src/gcc-11.x/x86_64-facebook-linux/libstdc++-v3/src/c++11/../../../.././libstdc++-v3/src/c++11/thread.cc:82:18
    becsedi#3 0x7f7632f6ec0e in start_thread /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/nptl/pthread_create.c:434:8
    becsedi#4 0x7f76330011db in clone3 /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81

UndefinedBehaviorSanitizer: integer-divide-by-zero buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h:33:40 in
```

Reviewed By: jiayuebao

Differential Revision: D39024188

fbshipit-source-id: 64ad644c360565e638fa3ca74616a315038382ab
byrnedj and others added 30 commits September 9, 2022 11:51
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
Initial support of NUMA bindings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants