forked from pmem/CacheLib
-
Notifications
You must be signed in to change notification settings - Fork 1
Background data movement lat #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielobiri
wants to merge
2,512
commits into
becsedi:develop
Choose a base branch
from
danielobiri:background-data-movement-lat
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Background data movement lat #5
danielobiri
wants to merge
2,512
commits into
becsedi:develop
from
danielobiri:background-data-movement-lat
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: GitHub commits: facebook/fbthrift@d184f6c facebook/litho@c866282 facebookincubator/velox@98a2c36 Reviewed By: zpao fbshipit-source-id: 81bcc5a220a28c442f9e54d9d0a5e7b0a5ffb150
Summary: GitHub commits: facebook@998d165 facebook/fb303@02afa6c facebook/fbthrift@e0e1add facebook/litho@7272351 facebook/mcrouter@0857360 facebook/proxygen@cde5910 facebook/rocksdb@7b9e970 facebook/watchman@fd12763 facebookexperimental/rust-shed@7818755 facebookresearch/beanmachine@90ad9f9 Reviewed By: zpao fbshipit-source-id: 64f4b0c1160c50ee08c9f16e4fbf026d9f6b53a6
Summary: GitHub commits: facebook/fb303@f61e366 facebook/fbthrift@e1cbd3d facebook/folly@618973d facebook/proxygen@9347632 facebook/wangle@804bf1e facebook/watchman@df88659 facebookexperimental/edencommon@2f3a295 facebookexperimental/rust-shed@b9b97c7 facebookincubator/fizz@9fa68c7 facebookincubator/katran@f506ca6 facebook/mvfst@ab9cb63 facebookincubator/velox@b8b9e1e facebookresearch/beanmachine@e1b3108 meta-pytorch/multipy@e8b0afb Reviewed By: zpao fbshipit-source-id: 3f857a68d319057e23fc3f974a901d61e9f61ea8
Summary: GitHub commits: facebook@7b8cba0 facebook/fb303@a5af802 facebook/fbthrift@a285107 facebook/folly@a67decb facebook/proxygen@8cc1b16 facebook/rocksdb@db7606a facebook/wangle@d08cceb facebook/watchman@9555470 facebookexperimental/edencommon@c275eea facebookexperimental/rust-shed@de3060c facebookincubator/fizz@5344a8f facebookincubator/katran@44c2125 facebook/mvfst@5047838 facebookincubator/velox@3658756 pytorch/FBGEMM@6d950a2 Reviewed By: zpao fbshipit-source-id: b14c3cc51d5dc1c2e96aac247c9b85f1a5a24f3d
Summary: GitHub commits: facebook@899d344 facebook/fb303@03dc7bd facebook/fbthrift@711bccb facebook/proxygen@9247ae8 facebook/wangle@36345b6 facebook/watchman@bbaa389 facebookexperimental/edencommon@ce4409d facebookexperimental/rust-shed@621c67a facebookincubator/fizz@cdf3e10 facebookincubator/katran@6e12525 facebook/mvfst@7dcf743 facebookincubator/velox@707e007 Reviewed By: zpao fbshipit-source-id: 130a0d218092f11cf21f4e7ae5d099fbf2fbabf3
Summary: GitHub commits: facebook@9cfbdaf facebook/fb303@54bda03 facebook/fbthrift@302f292 facebook/proxygen@b1a3530 facebook/rocksdb@616f3bd facebook/wangle@7a70299 facebook/watchman@0558b9e facebookexperimental/rust-shed@0ab9484 facebookincubator/katran@478b4d2 facebook/mvfst@a53d858 facebookresearch/mvit@8ee2015 Reviewed By: zpao fbshipit-source-id: 6df7ccf7549284d6d3b462240e5a58120f40f78c
Summary: GitHub commits: facebook@219313f facebook/fb303@54e5353 facebook/fbthrift@8951327 facebook/proxygen@18ead9a facebook/rocksdb@cbe2c6d facebook/watchman@a478c51 facebookexperimental/rust-shed@78bcd31 Reviewed By: zpao fbshipit-source-id: e88f2cad675647a7fe753db12a0b95d9653cf80c
…itor Summary: This diff has been automatically generated by the inpage editor. If you want to update this diff, go through the preview link that would be attached to the test plan. Please ensure you are editing the same page that was used to create this diff. Reviewed By: therealgymmy Differential Revision: D38958604 fbshipit-source-id: af5b72664dfe56464e59b896cd29473b758f8021
Summary: GitHub commits: facebook@2eda5e4 facebook/fb303@b9801e1 facebook/fbthrift@6918860 facebook/watchman@78cf88e facebookexperimental/rust-shed@ca8d3a5 Reviewed By: zpao fbshipit-source-id: bc16063d175cccbe817bb65bb928f14d15b43bfd
Summary: GitHub commits: facebook@81ad50a facebook/fb303@fff372f facebook/fbthrift@a0b09c4 facebook/folly@ec31037 facebook/litho@0e7a575 facebook/proxygen@180e27c facebook/rocksdb@d140fbf facebook/squangle@b069901 facebook/watchman@b687fa9 facebookexperimental/rust-shed@aaa203b facebookincubator/katran@704746b facebook/mvfst@e34ff18 facebookincubator/velox@3bb9726 facebookresearch/beanmachine@3f284f4 facebookresearch/multimodal@8fc2483 facebookresearch/Opacus-lab@c9c8b0c pytorch/FBGEMM@de510f4 meta-pytorch/multipy@befb5f4 Reviewed By: zpao fbshipit-source-id: 7018639aee42b0527ae014aa85d8f0e9b12b472b
Summary: I found a few users improperly passed `ttlSecs` as the 3rd parameter inside `insertOrReplace` API. Throw exception to avoid this. Reviewed By: therealgymmy Differential Revision: D38960198 fbshipit-source-id: 337819487eac83aa12cd2371da728e3f984998ab
Summary: GitHub commits: facebook@16ed597 facebook/fb303@8e47de4 facebook/fbthrift@a2a6528 facebook/proxygen@807d7aa facebook/wangle@363b38c facebook/watchman@2a6ce93 facebookexperimental/edencommon@c2fe9a1 facebookexperimental/rust-shed@367f4b1 facebookincubator/fizz@eac2c99 facebookincubator/katran@f73832e facebook/mvfst@82f1ac2 facebookincubator/velox@c337b92 facebookresearch/recipes@e37d958 pytorch/kineto@ffb0ef0 Reviewed By: zpao fbshipit-source-id: d9deb0752b54ca981942873bb48ff16bb14bf60a
Summary: GitHub commits: facebook@c5b8239 facebook/fb303@49bf3db facebook/fbthrift@dbe5567 facebook/proxygen@b40c90e facebook/wangle@2fabdf4 facebook/watchman@474643d facebookexperimental/rust-shed@709ea63 facebookincubator/katran@dfe5976 facebook/mvfst@e9af041 facebookresearch/recipes@88263ed meta-pytorch/multipy@ea75273 Reviewed By: zpao fbshipit-source-id: 16a2940debc1db948de0d79bbb5766b4ab7ec794
Summary: GitHub commits: facebook@012b35b facebook/fb303@972f077 facebook/fbthrift@122f0cc facebook/proxygen@b3117de facebook/watchman@264f9fe facebookexperimental/rust-shed@325f3c6 pytorch/kineto@2f8fa40 Reviewed By: zpao fbshipit-source-id: ae0a5e69cc8923462352f092cb9be2a4e6a4db67
Summary: GitHub commits: facebook@e2e2e00 facebook/fb303@bf47b75 facebook/fbthrift@3b79333 facebook/watchman@27791cc facebookexperimental/rust-shed@c78af95 Reviewed By: zpao fbshipit-source-id: 9926940a6375d6cdd7770b19673c9f80c86bd560
Summary: GitHub commits: facebook@8118866 facebook/fb303@63e5773 facebook/fbthrift@c127159 facebook/watchman@dce5c01 facebookexperimental/rust-shed@88af8c8 Reviewed By: zpao fbshipit-source-id: 7ca490b118c72dc4642edcd294ed384ecb862e13
Summary: GitHub commits: facebook/fbthrift@e795837 Reviewed By: zpao fbshipit-source-id: 5596f3b4d27c514c15c615f83d471a66a80844de
Summary: GitHub commits: facebook@160f46b facebook/fb303@674a456 facebook/fbthrift@fc1ee4c facebook/rocksdb@d95e376 facebook/watchman@bfb58fe facebookexperimental/rust-shed@9631cbb facebook/mvfst@feb1e8e Reviewed By: zpao fbshipit-source-id: b11da364bdb86448423ba12aeb429df55cd30c27
Summary: GitHub commits: facebook@36f109a facebook/fb303@a046f96 facebook/fbthrift@5d76023 facebook/proxygen@41e050b facebook/watchman@329b541 facebookexperimental/rust-shed@b90f48c Reviewed By: zpao fbshipit-source-id: 4b2c32b28482fdc69c7e49ee2430c7a658599253
Summary: GitHub commits: facebook/fbthrift@1e2c611 facebookarchive/profilo@befd6ae Reviewed By: zpao fbshipit-source-id: 1e6d60daa672ac5213510fe0d99f7ed071c85001
Summary: GitHub commits: facebook/fbthrift@a3fe0f1 Reviewed By: zpao fbshipit-source-id: 207d5e36e99a8b686a444a38a88449327f717036
Summary: GitHub commits: facebook@d994bc1 facebook/fb303@c04327a facebook/fbthrift@dcc6674 facebook/watchman@e7869ad facebookexperimental/rust-shed@6d9c49f facebookincubator/velox@1f0dc95 Reviewed By: zpao fbshipit-source-id: edb34b9ef6a1c0af4392ccecdba6be3bd462f99f
Summary: GitHub commits: facebook/fbthrift@35478e7 facebook/litho@20d1c9e Reviewed By: zpao fbshipit-source-id: 4046d0887f0522916b588b2d0c4274a7710654dc
Summary: GitHub commits: facebook/folly@05b1dc5 Reviewed By: zpao fbshipit-source-id: 5085b6b37522dac4142059011f3f4254653932fd
Summary: GitHub commits: facebook@08054c8 facebook/fb303@bf159da facebook/fbthrift@290f43b facebook/litho@ac158d6 facebook/proxygen@11ff78d facebook/wangle@df294f1 facebook/watchman@afeb49b facebookexperimental/edencommon@3e527f6 facebookincubator/fizz@77e51ef facebookincubator/katran@6df825e facebook/mvfst@aad0f6f facebookincubator/velox@456c9a6 Reviewed By: zpao fbshipit-source-id: 4a2618ddb759ce7dffd360cceff870d9c297d295
Summary: GitHub commits: facebook@bce01e5 facebook/fb303@9f5ad73 facebook/fbthrift@57e24e5 facebook/proxygen@d119f4a facebook/wangle@7ce175d facebook/watchman@59cf01c facebookexperimental/rust-shed@54233a4 facebookincubator/katran@b335476 facebook/mvfst@896bd82 Reviewed By: zpao fbshipit-source-id: bd9532c15227eb90cac4b5f968ec800edd459d7e
Summary: GitHub commits: facebook@ad5a8e7 facebook/fb303@4fc46a7 facebook/fbthrift@f9c7386 facebook/folly@fc64f53 facebook/proxygen@a76ac01 facebook/rocksdb@7fbee01 facebook/watchman@e87a3ae facebookexperimental/rust-shed@506a4b3 Reviewed By: zpao fbshipit-source-id: 60736f4a28b6d2229fe90d2d68ea36ce06d9db59
Summary: GitHub commits: facebook@fea7fc6 facebook/fb303@5aabf71 facebook/fbthrift@9b08bbe facebook/litho@547f85c facebook/proxygen@3b83409 facebook/wangle@ec838b4 facebook/watchman@c79a5de facebookexperimental/edencommon@48ac869 facebookexperimental/rust-shed@90db07c facebookincubator/fizz@802f22f facebookincubator/katran@bd08dd3 facebook/mvfst@543905c facebookincubator/velox@71805df Reviewed By: zpao fbshipit-source-id: 059ddb991750f414ce7d994140faf9c94350ba31
Summary: AdRanker ASAN canary flagged a possible UBSan violation. ## Error Failed Run: https://fburl.com/servicelab/apytosry ``` #0 0x562e3adb59bc in facebook::cachelib::objcache2::ObjectCacheSizeController<facebook::cachelib::CacheAllocator<facebook::cachelib::LruCacheTrait> >::work() buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h #1 0x562de7610f78 in facebook::cachelib::PeriodicWorker::loop() fbcode/cachelib/common/PeriodicWorker.cpp:55 becsedi#2 0x7f7632c524e4 in execute_native_thread_routine /home/engshare/third-party2/libgcc/11.x/src/gcc-11.x/x86_64-facebook-linux/libstdc++-v3/src/c++11/../../../.././libstdc++-v3/src/c++11/thread.cc:82:18 becsedi#3 0x7f7632f6ec0e in start_thread /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/nptl/pthread_create.c:434:8 becsedi#4 0x7f76330011db in clone3 /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 UndefinedBehaviorSanitizer: integer-divide-by-zero buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h:33:40 in ``` Reviewed By: jiayuebao Differential Revision: D39024188 fbshipit-source-id: 64ad644c360565e638fa3ca74616a315038382ab
Summary: GitHub commits: facebook@fa5fa64 facebook/fb303@88072a5 facebook/fbthrift@357c416 facebook/folly@0485ce6 facebook/mcrouter@47b7acd facebook/proxygen@016e32c facebook/rocksdb@418b36a facebook/wangle@b2db096 facebook/watchman@883b0ae facebookexperimental/edencommon@999e2f1 facebookexperimental/rust-shed@742c4d0 facebookincubator/fizz@b7e72db facebookincubator/katran@b3290fe facebook/mvfst@0cf312d facebookincubator/velox@708435b facebookresearch/beanmachine@0584aba facebookresearch/multimodal@7069b83 pytorch/FBGEMM@6f1bef4 Reviewed By: zpao fbshipit-source-id: f435d630dd1de382901c8a3f67996f37f428d5f9
Hot queue iterator for 2Q. Will start at Hot queue and move to Warm queue if hot queue is exhausted. Useful for promotion semantics if using 2Q replacement. rebased on to develop and added some tests.
Fix deprecation warn
Initial support of NUMA bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.