New dynamic #6
Open
New dynamic #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: GitHub commits: facebook@16ed597 facebook/fb303@8e47de4 facebook/fbthrift@a2a6528 facebook/proxygen@807d7aa facebook/wangle@363b38c facebook/watchman@2a6ce93 facebookexperimental/edencommon@c2fe9a1 facebookexperimental/rust-shed@367f4b1 facebookincubator/fizz@eac2c99 facebookincubator/katran@f73832e facebook/mvfst@82f1ac2 facebookincubator/velox@c337b92 facebookresearch/recipes@e37d958 pytorch/kineto@ffb0ef0 Reviewed By: zpao fbshipit-source-id: d9deb0752b54ca981942873bb48ff16bb14bf60a
Summary: GitHub commits: facebook@c5b8239 facebook/fb303@49bf3db facebook/fbthrift@dbe5567 facebook/proxygen@b40c90e facebook/wangle@2fabdf4 facebook/watchman@474643d facebookexperimental/rust-shed@709ea63 facebookincubator/katran@dfe5976 facebook/mvfst@e9af041 facebookresearch/recipes@88263ed meta-pytorch/multipy@ea75273 Reviewed By: zpao fbshipit-source-id: 16a2940debc1db948de0d79bbb5766b4ab7ec794
Summary: GitHub commits: facebook@012b35b facebook/fb303@972f077 facebook/fbthrift@122f0cc facebook/proxygen@b3117de facebook/watchman@264f9fe facebookexperimental/rust-shed@325f3c6 pytorch/kineto@2f8fa40 Reviewed By: zpao fbshipit-source-id: ae0a5e69cc8923462352f092cb9be2a4e6a4db67
Summary: GitHub commits: facebook@e2e2e00 facebook/fb303@bf47b75 facebook/fbthrift@3b79333 facebook/watchman@27791cc facebookexperimental/rust-shed@c78af95 Reviewed By: zpao fbshipit-source-id: 9926940a6375d6cdd7770b19673c9f80c86bd560
Summary: GitHub commits: facebook@8118866 facebook/fb303@63e5773 facebook/fbthrift@c127159 facebook/watchman@dce5c01 facebookexperimental/rust-shed@88af8c8 Reviewed By: zpao fbshipit-source-id: 7ca490b118c72dc4642edcd294ed384ecb862e13
Summary: GitHub commits: facebook/fbthrift@e795837 Reviewed By: zpao fbshipit-source-id: 5596f3b4d27c514c15c615f83d471a66a80844de
Summary: GitHub commits: facebook@160f46b facebook/fb303@674a456 facebook/fbthrift@fc1ee4c facebook/rocksdb@d95e376 facebook/watchman@bfb58fe facebookexperimental/rust-shed@9631cbb facebook/mvfst@feb1e8e Reviewed By: zpao fbshipit-source-id: b11da364bdb86448423ba12aeb429df55cd30c27
Summary: GitHub commits: facebook@36f109a facebook/fb303@a046f96 facebook/fbthrift@5d76023 facebook/proxygen@41e050b facebook/watchman@329b541 facebookexperimental/rust-shed@b90f48c Reviewed By: zpao fbshipit-source-id: 4b2c32b28482fdc69c7e49ee2430c7a658599253
Summary: GitHub commits: facebook/fbthrift@1e2c611 facebookarchive/profilo@befd6ae Reviewed By: zpao fbshipit-source-id: 1e6d60daa672ac5213510fe0d99f7ed071c85001
Summary: GitHub commits: facebook/fbthrift@a3fe0f1 Reviewed By: zpao fbshipit-source-id: 207d5e36e99a8b686a444a38a88449327f717036
Summary: GitHub commits: facebook@d994bc1 facebook/fb303@c04327a facebook/fbthrift@dcc6674 facebook/watchman@e7869ad facebookexperimental/rust-shed@6d9c49f facebookincubator/velox@1f0dc95 Reviewed By: zpao fbshipit-source-id: edb34b9ef6a1c0af4392ccecdba6be3bd462f99f
Summary: GitHub commits: facebook/fbthrift@35478e7 facebook/litho@20d1c9e Reviewed By: zpao fbshipit-source-id: 4046d0887f0522916b588b2d0c4274a7710654dc
Summary: GitHub commits: facebook/folly@05b1dc5 Reviewed By: zpao fbshipit-source-id: 5085b6b37522dac4142059011f3f4254653932fd
Summary: GitHub commits: facebook@08054c8 facebook/fb303@bf159da facebook/fbthrift@290f43b facebook/litho@ac158d6 facebook/proxygen@11ff78d facebook/wangle@df294f1 facebook/watchman@afeb49b facebookexperimental/edencommon@3e527f6 facebookincubator/fizz@77e51ef facebookincubator/katran@6df825e facebook/mvfst@aad0f6f facebookincubator/velox@456c9a6 Reviewed By: zpao fbshipit-source-id: 4a2618ddb759ce7dffd360cceff870d9c297d295
Summary: GitHub commits: facebook@bce01e5 facebook/fb303@9f5ad73 facebook/fbthrift@57e24e5 facebook/proxygen@d119f4a facebook/wangle@7ce175d facebook/watchman@59cf01c facebookexperimental/rust-shed@54233a4 facebookincubator/katran@b335476 facebook/mvfst@896bd82 Reviewed By: zpao fbshipit-source-id: bd9532c15227eb90cac4b5f968ec800edd459d7e
Summary: GitHub commits: facebook@ad5a8e7 facebook/fb303@4fc46a7 facebook/fbthrift@f9c7386 facebook/folly@fc64f53 facebook/proxygen@a76ac01 facebook/rocksdb@7fbee01 facebook/watchman@e87a3ae facebookexperimental/rust-shed@506a4b3 Reviewed By: zpao fbshipit-source-id: 60736f4a28b6d2229fe90d2d68ea36ce06d9db59
Summary: GitHub commits: facebook@fea7fc6 facebook/fb303@5aabf71 facebook/fbthrift@9b08bbe facebook/litho@547f85c facebook/proxygen@3b83409 facebook/wangle@ec838b4 facebook/watchman@c79a5de facebookexperimental/edencommon@48ac869 facebookexperimental/rust-shed@90db07c facebookincubator/fizz@802f22f facebookincubator/katran@bd08dd3 facebook/mvfst@543905c facebookincubator/velox@71805df Reviewed By: zpao fbshipit-source-id: 059ddb991750f414ce7d994140faf9c94350ba31
Summary: AdRanker ASAN canary flagged a possible UBSan violation. ## Error Failed Run: https://fburl.com/servicelab/apytosry ``` #0 0x562e3adb59bc in facebook::cachelib::objcache2::ObjectCacheSizeController<facebook::cachelib::CacheAllocator<facebook::cachelib::LruCacheTrait> >::work() buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h #1 0x562de7610f78 in facebook::cachelib::PeriodicWorker::loop() fbcode/cachelib/common/PeriodicWorker.cpp:55 becsedi#2 0x7f7632c524e4 in execute_native_thread_routine /home/engshare/third-party2/libgcc/11.x/src/gcc-11.x/x86_64-facebook-linux/libstdc++-v3/src/c++11/../../../.././libstdc++-v3/src/c++11/thread.cc:82:18 becsedi#3 0x7f7632f6ec0e in start_thread /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/nptl/pthread_create.c:434:8 becsedi#4 0x7f76330011db in clone3 /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81 UndefinedBehaviorSanitizer: integer-divide-by-zero buck-out/v2/gen/fbcode/47d914adeee3d982/cachelib/experimental/objcache2/__object-cache__/headers/cachelib/experimental/objcache2/ObjectCacheSizeController-inl.h:33:40 in ``` Reviewed By: jiayuebao Differential Revision: D39024188 fbshipit-source-id: 64ad644c360565e638fa3ca74616a315038382ab
Summary: GitHub commits: facebook@fa5fa64 facebook/fb303@88072a5 facebook/fbthrift@357c416 facebook/folly@0485ce6 facebook/mcrouter@47b7acd facebook/proxygen@016e32c facebook/rocksdb@418b36a facebook/wangle@b2db096 facebook/watchman@883b0ae facebookexperimental/edencommon@999e2f1 facebookexperimental/rust-shed@742c4d0 facebookincubator/fizz@b7e72db facebookincubator/katran@b3290fe facebook/mvfst@0cf312d facebookincubator/velox@708435b facebookresearch/beanmachine@0584aba facebookresearch/multimodal@7069b83 pytorch/FBGEMM@6f1bef4 Reviewed By: zpao fbshipit-source-id: f435d630dd1de382901c8a3f67996f37f428d5f9
Summary: GitHub commits: facebook@128f5f7 facebook/fb303@d98aef7 facebook/fbthrift@cedda79 facebook/folly@3a67b58 facebook/proxygen@5d10b9a facebook/wangle@48603af facebook/watchman@f86696f facebookexperimental/edencommon@7d67773 facebookexperimental/rust-shed@b45bc82 facebookincubator/fizz@9f6d617 facebookincubator/katran@8e66acc facebook/mvfst@8507e7a facebookincubator/velox@9d390de facebookresearch/beanmachine@3e446cf Reviewed By: zpao fbshipit-source-id: cb4222941967002be20673445933d7e07e272a45
Summary: GitHub commits: facebook@ce60f7c facebook/fb303@0e5f81f facebook/fbthrift@7feb30b facebook/mcrouter@b81aa1d facebook/proxygen@8fbe9a3 facebook/rocksdb@3f57d84 facebook/squangle@49d7615 facebook/wangle@9e8a662 facebook/watchman@6b17bef facebookexperimental/edencommon@7234916 facebookexperimental/rust-shed@d5388cb facebookincubator/fizz@b29e0e2 facebookincubator/katran@d319a0b facebook/mvfst@0ae7902 facebookincubator/velox@7638b3c facebookresearch/multimodal@f0eddf2 Reviewed By: zpao fbshipit-source-id: 453b925ba34a1adff66c8b98a7e8c224fe5ca66a
Summary: GitHub commits: facebook@c4f5b84 facebook/fb303@3d5edd7 facebook/fbthrift@224b93f facebook/proxygen@b771ed5 facebook/wangle@d83df24 facebook/watchman@6f9476a facebookexperimental/rust-shed@72fde0c facebookincubator/katran@495a8d4 facebook/mvfst@f149966 facebookresearch/FLSim@d504076 facebookresearch/recipes@051be7c Reviewed By: zpao fbshipit-source-id: 5134d65177324797bfc3ffd94881eee3d23ab624
Summary: GitHub commits: facebook@ba3ccf5 facebook/fb303@36beb03 facebook/fbthrift@5d2051c facebook/folly@41c3055 facebook/proxygen@e74f7e4 facebook/rocksdb@d9e71fb facebook/watchman@6059bb4 facebookexperimental/rust-shed@947798d facebookincubator/fizz@1d5eaf7 facebookincubator/velox@ce230a6 facebookresearch/beanmachine@9c751ed Reviewed By: zpao fbshipit-source-id: 79c1fbb73f30419cca8be1995e2274bcfcc9e76f
Summary: GitHub commits: facebook@6415a20 facebook/fb303@4b25de9 facebook/fbthrift@1848840 facebook/proxygen@24907f6 facebook/wangle@bd31953 facebook/watchman@b886057 facebookexperimental/edencommon@e92a6cc facebookexperimental/rust-shed@b356529 facebookincubator/fizz@a71dfba facebookincubator/katran@20b60fb facebook/mvfst@cf8601b facebookincubator/velox@8bd3b7c Reviewed By: zpao fbshipit-source-id: 3b8b404e1f5691d69f9013b77ea3233213eb6db7
Summary: GitHub commits: facebook@39acab4 facebook/fb303@3234dc3 facebook/fbthrift@999834f facebook/proxygen@cfc18eb facebook/wangle@75b0403 facebook/watchman@ea8f12f facebookexperimental/rust-shed@b2d59d9 facebookincubator/katran@6e1042c facebook/mvfst@07070c3 Reviewed By: zpao fbshipit-source-id: a972af20c1f71403d8bb5fd9bf1811b179c30ce3
Summary: GitHub commits: facebook@837502f facebook/fb303@b1c3a9a facebook/fbthrift@a78e6fc facebook/proxygen@3934cf1 facebook/watchman@9642146 facebookexperimental/rust-shed@7fcc9d9 Reviewed By: zpao fbshipit-source-id: 6869e1865236bbd9d9760aabc86d78506c45981a
Summary: GitHub commits: facebook@6014a00 facebook/fb303@80e6a07 facebook/fbthrift@4112499 facebook/folly@55e9ce2 facebook/watchman@848e79e facebookexperimental/rust-shed@1eb8488 Reviewed By: zpao fbshipit-source-id: d60e4648ef714b83cd5266827399291881775550
Summary: GitHub commits: facebook@f74386a facebook/fb303@7ee542b facebook/fbthrift@c1d009f facebook/folly@2d2e79d facebook/proxygen@f55bf37 facebook/wangle@5d8666b facebook/watchman@8491ac9 facebookexperimental/edencommon@0ae991d facebookexperimental/rust-shed@33cb221 facebookincubator/fizz@c9c30ac facebookincubator/katran@3ca22f2 facebook/mvfst@96bc676 facebookincubator/velox@fb245c2 Reviewed By: zpao fbshipit-source-id: 45145b25a9bf6a805df1db0b3d948e90f846ecd3
Summary: GitHub commits: facebook@7eb93a6 facebook/fb303@c5a9849 facebook/fbthrift@52b8a2c facebook/proxygen@8394f41 facebook/wangle@e525712 facebook/watchman@52c7aed facebookexperimental/edencommon@afbb557 facebookexperimental/rust-shed@9678798 facebookincubator/fizz@d4eeb9e facebookincubator/katran@19fc9ec facebook/mvfst@aaa3bc6 facebookincubator/velox@fafa339 Reviewed By: zpao fbshipit-source-id: 8ba5e8be321e70ac6e07db9dc23bdb9374f26c06
Summary: GitHub commits: facebook@95cfb64 facebook/fb303@2aa965b facebook/fbthrift@84fd706 facebook/folly@b428d98 facebook/proxygen@38f43df facebook/wangle@afb5274 facebook/watchman@34d6767 facebookexperimental/rust-shed@2ba0a9e facebookincubator/katran@ccbf1ff facebook/mvfst@450f90f Reviewed By: zpao fbshipit-source-id: b20929d6f6224ed54905d3b5d71a1c0f06cc19a8
Initial support of NUMA bindings
The issue was caused by incorrect behaviour of the CacheAllocator<CacheTrait>::tryEvictToNextMemoryTier method in case the evicted item is expired. We cannot simply return a handle to it, but we need to remove it from the access container and MM container.
Fix ReaperSkippingSlabTraversalWhileSlabReleasing test
Fix moveRegularItemWithSync and add tests
Background data movement using periodic workers. Attempts to evict/promote items per given thresholds for each class. These reduce p99 latency since there is a higher chance that an allocation slot is free in the tier we are allocating in.
This reverts commit 033e09e.
This reverts commit 5da310f.
This reverts commit 033e09e.
This reverts commit c8b3a1c.
This reverts commit 27ec479.
This reverts commit 337d25f.
cosmetic changes made after code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.