remove depenency on swift plugin #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted by cordova now.
…nfig.xml if needed)
|
Possibly this? https://forum.ionicframework.com/t/ios-build-issue-value-for-swift-version-cannot-be-empty/186855/3 |
|
Well, it worked fine this time I did a fresh build from scratch. If it works for you too then I'd say it's good. It looks like Here's an example of another plugin that did this same thing: BTW, there's some chance of conflicting swift versions with workaround described here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #101
I tested this and it works on iOS. I don't think it should affect Android at all, but I'll check it.
But I did get the error
error: Value for SWIFT_VERSION cannot be empty.but then I manually set the Swift Version in XCode and it worked. Not sure why<preference name="SwiftVersion" value="4.0" />is not taking effect. Maybe a bug in cordova?