Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bull): support removing repeatable jobs #574

Merged
merged 2 commits into from
Oct 18, 2022
Merged

feat(bull): support removing repeatable jobs #574

merged 2 commits into from
Oct 18, 2022

Conversation

roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented Oct 16, 2022 •
edited
Loading

Changes Made

Add new button to remove repeatable jobs if a job is linked to one

Potential Risks

None, this should be only be visible for bull package

Test Plan

Make sure there is not repeatable job in delayed state when you click remove repeatable button

Checklist

  • I've increased test coverage
  • Since this is a public repository, I've checked I'm not publishing private data in the code, commit comments, or this PR.

@roggervalf roggervalf enabled auto-merge (squash) October 16, 2022 01:50
@roggervalf
Copy link
Collaborator Author

Prs requires at least 1 approval

@bradvogel
Copy link
Contributor

@roggervalf I unfortunately have time to review. Is there someone else from your team that can review?

@roggervalf
Copy link
Collaborator Author

hi @bradvogel, could you please add @richardmaysundo?, he is from my team and can help on reviewing prs

@roggervalf
Copy link
Collaborator Author

roggervalf commented Oct 17, 2022 •
edited
Loading

can we be added as collaborators in https://www.npmjs.com/package/bull-arena? https://www.npmjs.com/~rogger.794, https://www.npmjs.com/~richardmaysundo

@bradvogel
Copy link
Contributor

@roggervalf I made you admin on this repository. You can add whoever you'd like to.

richardmaysundo
richardmaysundo approved these changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@richardmaysundo richardmaysundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only need to rename variable 'r' here https://github.com/bee-queue/arena/pull/574/files#diff-e36254d8c0d26892d85dda23a915f524ec640aadfb50e7dc4bc0abe1894934dcR140

@roggervalf roggervalf merged commit 29528cf into master Oct 18, 2022
@roggervalf roggervalf deleted the feat-remove-repeatable branch October 18, 2022 15:57
beequeueci pushed a commit that referenced this pull request Oct 18, 2022
@semantic-release-bot
chore(release): 3.30.0 [skip ci]
c72a106 
## [3.30.0](v3.29.5...v3.30.0) (2022-10-18)

### Features

* **bull:** support removing repeatable jobs ([#574](#574)) ([29528cf](29528cf))
@beequeueci
Copy link
Collaborator

🎉 This PR is included in version 3.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardmaysundo richardmaysundo richardmaysundo approved these changes

@bradvogel bradvogel Awaiting requested review from bradvogel

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roggervalf @bradvogel @beequeueci @richardmaysundo