Styling and formatting fixes for jobDetails view #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wearhere
reviewed
Jan 4, 2018
| @@ -101,7 +101,7 @@ | |||
| </h4> | |||
| </a> | |||
| <div id="collapse{{encodeIdAttr this.id}}" class="collapse"> | |||
| {{> dashboard/jobDetails this basePath=../basePath displayJobInline=true queueName=../queueName queueHost=../queueHost jobState=../state }} | |||
| {{~> dashboard/jobDetails this basePath=../basePath displayJobInline=true queueName=../queueName queueHost=../queueHost jobState=../state }} | |||
There was a problem hiding this comment.
I did not know about using tildes to control whitespace, neat!
|
Thanks! published as 2.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<pre>formatting usinghighlight.js<pre>tag and whitespace control when viewing the template inline<pre>tag with overflow-y: scrollthis.returnvalueusing the json helper as well in case the returnvalue is not just a stringIf you don't want to accept all changes, I can make a separate pull request for just the whitespace control so that the
<pre>tags look proper on the inline view.