Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bullmq support #50

Merged
merged 1 commit into from
Nov 25, 2020
Merged

feat: bullmq support #50

merged 1 commit into from
Nov 25, 2020

Conversation

gtpan77
Copy link
Contributor

@gtpan77 gtpan77 commented Nov 24, 2020 •
edited by skeggse
Loading

Fixes: #37

@skeggse skeggse added enhancement New feature or request bullmq labels Nov 24, 2020
@skeggse skeggse self-assigned this Nov 24, 2020
skeggse
skeggse approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@skeggse skeggse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm. How do you think we want to handle semver? It definitely feels like this is a minor rev (which corresponds to the feat tag), but that results in docker-arena's version diverging from upstream. Maybe we publish a dummy version of arena?

@gtpan77
Copy link
Contributor Author

gtpan77 commented Nov 24, 2020

This change also looks like minor revision to me. What other changes we have to do if we want to publish dummy version of arena?

@skeggse
Copy link
Member

skeggse commented Nov 24, 2020

I just mean that we'd republish the same code as in latest arena as a new minor version so they stay in sync. I'll take a look later today.

@gtpan77
Copy link
Contributor Author

gtpan77 commented Nov 24, 2020

Okay, let me know if I can contribute in some way.

skeggse added a commit to bee-queue/arena that referenced this pull request Nov 25, 2020
@skeggse
feat: support bullmq in docker image
c10a294 
This release exists solely to track the version bump in docker-arena,
per bee-queue/docker-arena#50. We aim to maintain a major+minor version
parity between artifacts of the two projects.
beequeueci pushed a commit to bee-queue/arena that referenced this pull request Nov 25, 2020
@semantic-release-bot
chore(release): 3.6.0 [skip ci]
d37c668 
## [3.6.0](v3.5.0...v3.6.0) (2020-11-25)

### Features

* support bullmq in docker image ([c10a294](c10a294)), closes [bee-queue/docker-arena#50](bee-queue/docker-arena#50)
@skeggse skeggse merged commit 360d3c0 into bee-queue:default Nov 25, 2020
@skeggse skeggse added this to the 3.6.0 milestone Nov 25, 2020
@beequeueci
Copy link
Collaborator

🎉 This PR is included in version 3.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeggse skeggse skeggse approved these changes

Assignees

@skeggse skeggse

Labels
bullmq enhancement New feature or request released
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

add bullmq support
3 participants
@gtpan77 @skeggse @beequeueci