Change positioning of timer::pause in human checker fixing bug where API would panic no matter what #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously our logic looked like this: * Check to see if API is on, if it is return True * If it's not, pause human checker * Perform human checker This led to a glitch where the program would return with something, but the timer would still run and return a panic. As we always return True for the HumanChecker if our API is on, we do not need to worry about whether or not the data passes any human checks and can just pause it.
bee-san
changed the title
SkeletalDemise
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously our logic looked like this:
This led to a glitch where the program would return with something, but the timer would still run and return a panic.
As we always return True for the HumanChecker if our API is on, we do not need to worry about whether or not the data passes any human checks and can just pause it.