Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make searching filenames for matches optional #128

Merged
merged 3 commits into from
Aug 10, 2021
Merged

Conversation

amadejpapez
Copy link
Collaborator

@amadejpapez amadejpapez commented Aug 6, 2021

Previously PyWhat always added the name of the file to the search. This PR makes it optional, so if someone wants PyWhat to also search filenames for any matches, they can now do it with -if command.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API docs should be updated after this gets merged.

pywhat/what.py Outdated Show resolved Hide resolved
pywhat/what.py Outdated Show resolved Hide resolved
pywhat/what.py Outdated Show resolved Hide resolved
@click.option("-e", "--exclude", help="Disclude matches with these tags.")
@click.option("-e", "--exclude", help="Exclude matches with these tags.")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICEE!!!!!

@bee-san
Copy link
Owner

bee-san commented Aug 10, 2021

@amadejpapez you can merge if you want!! normally in industry ✨ when ew approve something, its up to you to merge it as you may want to add some things last minute etc :)

@amadejpapez amadejpapez merged commit da59c98 into main Aug 10, 2021
@amadejpapez amadejpapez deleted the search-filenames branch August 10, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants