Fix exploit token replacement when having multiple matches #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing my changes on !162, I noticed that there was a problem in the Exploit reporting when there were multiple matches in the file:
Looking at the code, I found the issue was caused by https://github.com/bee-san/pyWhat/blob/main/pywhat/regex_identifier.py#L31 where a shallow copy was used and the regex match reference was directly manipulated due to the same name. I have change the copy to deep and rename the matched expression data.
After fixing the issue, each token is replaced correspondingly: