added nano; simplify

[hexiro]

made some small changes which shouldn't affect logic and added nano.

changes:

• added nano
• replaced the 2nd snippet with the 1st

if sys.version_info < (3, 6):

if major < 3 or (major == 3 and minor < 6):

• made the Wikipedia link in scripts/get_file_sigs.py use https protocol
• replaced instances of dict() with {}
• replaced if / elses w/ ternary expressions
• replaced set([]) w/ {}
• replaced some for loops with list comprehensions

lmk what you think 👍🏼

[bee-san]

This is probably 1 because it require having the string nano or xrb in it :)

[hexiro]

i thought so too but I didn't want to over estimate. I can make that change today. What about the 10 checks failing?

[amadejpapez]

Try running pytest on your machine inside of the PyWhat directory, so that tests run and you can see the reason why ones are failing.

And don't forget to run black and isort for your code formatting. :)

[hexiro]

will do :)

[bee-san]

Failing because:

>       assert rarity_num == sorted(
            rarity_num, reverse=True
        ), "Regexes should be sorted by rarity in 'regex.json'. Regexes with rarity '1' are at the top of the file and '0' is at the bottom."

[hexiro]

Failing because:

>       assert rarity_num == sorted(

            rarity_num, reverse=True

        ), "Regexes should be sorted by rarity in 'regex.json'. Regexes with rarity '1' are at the top of the file and '0' is at the bottom."

gotcha gotcha that makes sense. Will change when i get the chance :)

[hexiro]

I'll check this out later when I'm on my home pc and make sure there are no more failing tests.
I've never used poetry before but it looks very cool, so thank you for exposing me to it!👍🏼

[hexiro]

does the position in regex.json affect the order of the matches? I left it at the bottom of the rarity: 1s because nano is quite uncommon (thus unlikely to be a false positive)

[bee-san]

Hey! Mind fixing the merge conflict and I can merge? Thanks!!! :)

[hexiro]

merge conflicts gone 🦀
p.s. you might want to squash and merge