feat: UPS tracking numbers

[P403n1x87]

⚠ Pull Requests not made with this template will be automatically closed 🔥

Prerequisites

• Have you read the documentation on contributing? https://github.com/bee-san/pyWhat/wiki/Adding-your-own-Regex

Why do we need this pull request?

• This PR adds the regex for UPS tracking numbers

What GitHub issues does this fix?

N. A.

Copy / paste of output

❯ pywhat 1Z123CAB9912345678    
Matched on: 1Z123CAB9912345678
Name: UPS Tracking Number
Link:  https://www.ups.com/track?tracknum=1Z123CAB9912345678

[ghost]

I would say that rarity should be lowered.

[P403n1x87]

Any suggestions? 🙂

[ghost]

Something around 0.3

[bee-san]

Why 0.3? I'd say higher like 0.5 or 0.6 because:

1. The string has to start with 1Z
2. It needs 7 chars 0-9A-Z
3. It has exactly 2 numbers
4. It has 8 numbers

Also, can we make it:

- ^(1Z[0-9A-Z]{6}[0-9]{2}[0-9]{8})$
- + ^(1Z[0-9A-Z]{6}[0-9]{10})$

?

[ghost]

I think 0.4 or 0.5. And yes, regex should be changed.

[P403n1x87]

The idea of the 2+8 split is because the first 2 digits in this group represent a service indicator code and perhaps it could be captured and handled in the future.

[P403n1x87]

Aside: I wonder if the "rarity" could be estimated more reliably through some entropy-based measure 🤔

[bee-san]

service indicator code

We have precedence for this called sub-categories. See the Mastercard / Phone Numbers regex. I am not sure it'll work on data in the middle of the regex, we may need to change the code for that :)

Aside: I wonder if the "rarity" could be estimated more reliably through some entropy-based measure 🤔

Probably! Currently I am estimating it based on what I see when people post this:

And also whether we have any false positives.

[ghost]

@P403n1x87 You can use subcategories with regex method for that.

[codecov-commenter]

Codecov Report

Merging #228 (62b3df8) into main (a5a4a3b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          15       15           
  Lines        1217     1217           
=======================================
  Hits         1127     1127           
  Misses         90       90           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a4a3b...62b3df8. Read the comment docs.