Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGTM: readme and documentation cleanup #7

Merged
merged 1 commit into from
May 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,11 @@ on:
jobs:
lgtm:
runs-on: ubuntu-latest
name: A job to say hello
name: True meaning of LGTM
steps:
- name: Checkout
uses: actions/checkout@v2
- name: LGTM
uses: ./
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
OCAMLRUNPARAM: b
39 changes: 39 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1 +1,40 @@
# LGTM

Who knows what the heck LGTM even stands for anyway?

Let's Get This Merged?

Let's Get this Money?

Looks Good To me?

something else?

This is an action that responds to the acronym in Pull Requests or issues with the true meaning of LGTM, or atleast up to the Random Number Generator.

Setup:

Add the `GH_TOKEN` secret to your repo with a token that has permission to comment on Issues.


```
cat .github/workflows/action.yaml

---

on:
issue_comment:
types: [created]

jobs:
lgtm:
runs-on: ubuntu-latest
name: True meaning of LGTM
steps:
- name: Checkout
uses: actions/checkout@v2
- name: LGTM
uses: beeceej/lgtm@v0.0.1
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
```
2 changes: 1 addition & 1 deletion src/main.ml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module LgtmAcronym = struct
let g = rand_from_list Words.g in
let t = rand_from_list Words.t in
let m = rand_from_list Words.m in
Printf.sprintf "*%s* *%s* *%s* *%s*" l g t m
Printf.sprintf "**%s** **%s** **%s** **%s**" l g t m
end

module Github = struct
Expand Down