BrowserStack Integration #1920
Merged
BrowserStack Integration #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e if we get these results in Travis.
…um as we primarily use Capybara sessions in testing.
…e response too flakey atm. Cleaned up code.
…e response too flakey atm. Cleaned up code.
…m the hooked browser info.
DeezyE
reviewed
May 29, 2020
| print_info "Exception Message: #{e.message}" | ||
| print_info "Exception Stack Trace: #{e.backtrace}" | ||
| if @driver.execute_script('return window.beef.session.get_hook_session_id().length').nil? && | ||
| e.class == NoMethodError |
jcrew99
reviewed
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please fill in this template where appropriate:
Category
Tests
Feature/Issue Description
This integration will allow BeEF to run any components of the test suite that require hooking/victim browser interaction against a matrix of Browser/Operating Systems and their different versions.
This will help ensure that future code added to BeEF work on both new and old systems, which is vital considering the nature of BeEF's functionality. Many of the older systems are those are would be most susceptible and we want to ensure that we have BeEF working against such environments.
Describe Changes
Specific tests now send encrypted traffic through to BrowserStack and the Selenium web-driver will run within their environment rather than on the host system of the Travis box running the test suite.
These tests are DISABLED by default when running the standard test command:
bundle exec rakeThe tests will only run when Travis-CI kicks off the test suite so functionally for users running testing locally there should be no change.
Test Cases
No new tests, although there were many modifications to the tests utilising a dummy victim to allow for this integration. Some cleanup was done on the code of those tests also.
Relevant Wiki Page
I have a Wiki page drafted up in Markdown, ready for the merge of this PR that details the baseline level of compatibility tested by this integration.