-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add scripts option(custom commands) #373
Conversation
example to use: 1. Go test with custom params or other test framework like ginkgo 2. Fronted tools like grunt 3. Other custom commands
the script maybe we can rename it to hook? |
it looks like the makefile's target. I like the idea. |
Hi, it seems the same as in package.json (npm), the call it scripts there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea, but I don't like the way scripts are added as commands dynamically. I prefer to have an additional run-script
command that will load the defined scripts from Beefile
and run them by name. For example: $ bee run-script test
@astaxie @amrfaissal |
seems that this feature is inspired by npm scripts.
|
@sergeylanzman For this PR I think we need to avoid the custom command to overwrite the current command, |
Just have a conversation with @sergeylanzman in slack. We agree that current implement is good enough to deliver. I think we all agree with this idea. @amrfaissal I think #377 also can merge into. But I like more short name for it. maybe |
@amrfaissal I just think about these two solution. support own command and just use the |
@astaxie At least "user-defined" commands should be separated from bee's default commands. Adding commands dynamically is a hack that is both flexible and confusing. |
Yea, that would make more sense. @sergeylanzman Could you help to create another PR to improve it? |
@astaxie yes create this.
command for run this |
I agree with this idea. @amrfaissal what's your opinion?
I have a window VM. please create a issue for me to track it |
1. add nonce parameter. 2. add sub in userinfo endpoint. Signed-off-by: 0x2a <stevesough@gmail.com>
example to use:
config in Beefile
like command name: command
This automatic add to commands

know issue not support windows(TODO), not test on linux
Thank for @BorisBorshevsky about idea:)