Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 4590: Forget to check URL when FilterChain invoke next() #4593

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Fix 4590: Forget to check URL when FilterChain invoke next() #4593

merged 3 commits into from
Apr 30, 2021

Conversation

flycash
Copy link
Collaborator

@flycash flycash commented Apr 27, 2021 •
edited
Loading

Close #4590

When the first filter match the url and then it invoke next, we should check URL again.

So we could not use FilterChain directly, we must wrap it.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@flycash flycash merged commit 1ac3c5a into beego:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flycash