Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs: multiFileLogWriter uses incorrect formatter #4943

Merged
merged 1 commit into from
May 16, 2022
Merged

Conversation

flycash
Copy link
Collaborator

@flycash flycash commented May 16, 2022

Closes #4912

@codecov-commenter
Copy link

Codecov Report

Merging #4943 (669bf69) into develop (174291a) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 669bf69 differs from pull request most recent head 18f45ca. Consider uploading reports for the commit 18f45ca to get more accurate results

@@             Coverage Diff             @@
##           develop    #4943      +/-   ##
===========================================
- Coverage    54.68%   54.66%   -0.03%     
===========================================
  Files          244      244              
  Lines        21768    21811      +43     
===========================================
+ Hits         11904    11922      +18     
- Misses        8909     8932      +23     
- Partials       955      957       +2     
Impacted Files Coverage Δ
core/logs/multifile.go 60.78% <0.00%> (ø)
server/web/server.go 16.97% <0.00%> (-1.05%) ⬇️
core/logs/file.go 66.07% <0.00%> (-0.90%) ⬇️
task/task.go 67.47% <0.00%> (-0.54%) ⬇️
client/httplib/filter/opentelemetry/filter.go 87.09% <0.00%> (+0.88%) ⬆️
server/web/router.go 71.01% <0.00%> (+1.04%) ⬆️
adapter/session/session.go 34.14% <0.00%> (+4.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 174291a...18f45ca. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

@flycash flycash merged commit 411fbb8 into beego:develop May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log SetFormatter Bug
2 participants