[fix][refactor] Deprecate OCLWriteNode and PTXWriteNode and fix store… #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes an issue with storing bytes into arrays.
Additionally, it removes the
OCLWriteNode
andPTXWriteNode
classes since they're no longer needed.Problem description
Running the
uk.ac.manchester.tornado.unittests.arrays.TestArrays#testInitByteArray
unit test before the patch would generate the following stores:The issue is that the data type is byte and we store it at a 4 byte address instead of 1 byte.
After the patch, the store becomes:
Backend/s tested
OS tested
Did you check on FPGAs?
If possible, check your changes on FPGAs.
How to test the new patch?
Run the unit tests. I've added the test below for this: