Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][refactor] Deprecate OCLWriteNode and PTXWriteNode and fix store… #131

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

gigiblender
Copy link
Member

@gigiblender gigiblender commented Jul 10, 2021

Description

This patch fixes an issue with storing bytes into arrays.
Additionally, it removes the OCLWriteNode and PTXWriteNode classes since they're no longer needed.

Problem description

Running the uk.ac.manchester.tornado.unittests.arrays.TestArrays#testInitByteArray unit test before the patch would generate the following stores:

  ul_128  =  ul_0 + 151L;
  *((__global int *) ul_128)  =  21;

The issue is that the data type is byte and we store it at a 4 byte address instead of 1 byte.

After the patch, the store becomes:

  ul_128  =  ul_0 + 151L;
  *((__global char *) ul_128)  =  21;

Backend/s tested

  • OpenCL
  • PTX

OS tested

  • Linux
  • OSx
  • Windows

Did you check on FPGAs?

If possible, check your changes on FPGAs.

  • Yes
  • No

How to test the new patch?

Run the unit tests. I've added the test below for this:

tornado-test.py -J"-Dtornado.opencl.priority=10" --verbose --printKernel uk.ac.manchester.tornado.unittests.arrays.TestArrays#testInitByteArray

@gigiblender gigiblender self-assigned this Jul 10, 2021
@gigiblender gigiblender added the bug Something isn't working label Jul 10, 2021
@jjfumero
Copy link
Member

LGTM. Thank you Florin.

@gigiblender gigiblender merged commit eb2e828 into beehive-lab:develop Jul 20, 2021
@gigiblender gigiblender deleted the dev/misc/florin branch January 12, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants