Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests and update to use the API try-with-resources #460

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

jjfumero
Copy link
Member

Description

Refactor tests and update to use the API try-with-resources

Problem description

n/ a.

Backend/s tested

Mark the backends affected by this PR.

  • OpenCL
  • PTX
  • SPIRV

OS tested

Mark the OS where this PR is tested.

  • Linux
  • OSx
  • Windows

Did you check on FPGAs?

If it is applicable, check your changes on FPGAs.

  • Yes
  • No

How to test the new patch?

For each backend:

make tests

Copy link
Member

@mikepapadim mikepapadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one thing that is not related with the PR directly.
We should update the Tornado Insight plugin to promote the use of try with resources.

@jjfumero jjfumero merged commit 24668a9 into beehive-lab:develop Jun 25, 2024
2 checks passed
@jjfumero jjfumero deleted the update/tests/api branch June 25, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants